Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store evidence #156

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Store evidence #156

wants to merge 5 commits into from

Conversation

vetlewi
Copy link
Collaborator

@vetlewi vetlewi commented Nov 2, 2020

I've added an attribute to the ResultsNormalized to store the global evidence from the MultiNest results. Could be useful down the line.

vetlewi and others added 4 commits November 2, 2020 10:53
The evidence can sometimes be useful when comparing different models. We should store this value.
Store the global evidence when normalizing the NLD
Copy link
Collaborator

@fzeiser fzeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

How does this act when one employs the "stagewise" normalization? normalizeStagewise in EnsembleNormalizer? I havn't thought "enough" about it, but I assume the evidence should be multiplied somehow by the distance of the chosen B (-> Gg) from the experimental Gg. So this process here should modify the evidence I guess:

# sample B from the gaussian uncertainty for each nld
B = self.normalizer_gsf.res.pars["B"]
N = len(self.normalizer_gsf.res.samples["A"])
self.normalizer_gsf.res.samples["B"] = scipynorm.rvs(loc=B[0],
scale=B[1],
size=N)

@vetlewi
Copy link
Collaborator Author

vetlewi commented Nov 3, 2020

Good idea.

How does this act when one employs the "stagewise" normalization? normalizeStagewise in EnsembleNormalizer? I havn't thought "enough" about it, but I assume the evidence should be multiplied somehow by the distance of the chosen B (-> Gg) from the experimental Gg. So this process here should modify the evidence I guess:

# sample B from the gaussian uncertainty for each nld
B = self.normalizer_gsf.res.pars["B"]
N = len(self.normalizer_gsf.res.samples["A"])
self.normalizer_gsf.res.samples["B"] = scipynorm.rvs(loc=B[0],
scale=B[1],
size=N)

Huh, haven't though about that. I guess it depends on the likelihood and prior to be separable (with regards to Gg)? I don't feel like I know enough Bayesian statistics to confidently give an answer :p

@fzeiser
Copy link
Collaborator

fzeiser commented Nov 3, 2020

Unless this is very urgent, I'll think more about it after I've handed in my thesis in December. Writing on the main body of it now ;).

@fzeiser fzeiser marked this pull request as draft November 3, 2020 18:59
@fzeiser fzeiser added the Suggestion Suggestion for new feature/changes label Nov 3, 2020
@vetlewi
Copy link
Collaborator Author

vetlewi commented Nov 4, 2020

Unless this is very urgent, I'll think more about it after I've handed in my thesis in December. Writing on the main body of it now ;).

Not very urgent. Can always pull to a local branch for now.

@fzeiser fzeiser marked this pull request as ready for review January 18, 2021 11:30
Copy link
Collaborator

@fzeiser fzeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have difficulties to see how to correctly implement this for the sequential normalization. It somehow bothers me that we would combine a Bayesian model (nld normalization) with the frequentist Gg normalization and still call it a global evidence etc.

Suggestion: Simply store evidence only for NormalizerSimultan. (For the other normalization mode I somehow doubt that it makes sens.)

  • remove evidence from NormalizerNLD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion Suggestion for new feature/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants