Removed not working correctly Github Action with Test Results

Added Directory.Build.props and removed some commonly shared settings
Renamed project Core.Streaming.Kafka into Core.Kafka

.github/workflows/build.dotnet.yml

@@ -29,14 +29,7 @@ jobs:
               run: dotnet build --configuration Release --no-restore
 
             - name: Run tests
-              run: dotnet test --configuration Release --no-build --filter Category!=SkipCI --logger "trx;LogFileName=test-results.trx"
-
-            - name: Upload test results
-              uses: actions/upload-artifact@v2
-              if: success() || failure()
-              with:
-                name: test-results
-                path: '**/test-results.trx'
+              run: dotnet test --configuration Release --no-build --filter Category!=SkipCI
 
             - name: Stop containers
               if: always()

CQRS.Tests/CQRS.Tests.csproj

@@ -2,10 +2,6 @@
 
     <PropertyGroup>
         <TargetFramework>net6.0</TargetFramework>
-        <Nullable>enable</Nullable>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-        <VSTestLogger>trx%3bLogFileName=$(MSBuildProjectName).trx</VSTestLogger>
-        <VSTestResultsDirectory>$(MSBuildThisFileDirectory)/bin/TestResults/$(TargetFramework)</VSTestResultsDirectory>
     </PropertyGroup>
 
     <ItemGroup>

CQRS.Tests/Commands/Commands.cs

@@ -1,6 +1,3 @@
-using System.Collections.Generic;
-using System.Threading;
-using System.Threading.Tasks;
 using CQRS.Tests.TestsInfrasructure;
 using MediatR;
 using SharpTestsEx;

CQRS.Tests/Queries/Queries.cs

@@ -1,7 +1,3 @@
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
 using CQRS.Tests.TestsInfrasructure;
 using MediatR;
 using SharpTestsEx;

CQRS.Tests/TestsInfrasructure/ServiceLocator.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using MediatR;
+using MediatR;
 
 namespace CQRS.Tests.TestsInfrasructure;
 

Core.Api.Testing/ApiFixture.cs

@@ -1,9 +1,5 @@
-using System;
-using System.Collections.Generic;
 using System.Net;
-using System.Net.Http;
 using System.Net.Http.Headers;
-using System.Threading.Tasks;
 using Core.Serialization.Newtonsoft;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.TestHost;

Core.Api.Testing/Core.Api.Testing.csproj

@@ -2,8 +2,6 @@
 
     <PropertyGroup>
         <TargetFramework>net6.0</TargetFramework>
-        <Nullable>enable</Nullable>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
         <IsTestProject>false</IsTestProject>
     </PropertyGroup>
 

Core.Api.Testing/ResponseExtensions.cs

@@ -1,5 +1,3 @@
-using System.Net.Http;
-using System.Threading.Tasks;
 using Core.Serialization.Newtonsoft;
 using FluentAssertions;
 

Core.Api.Testing/TestContext.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
 using System.Diagnostics;
-using System.Net.Http;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.TestHost;
 using Microsoft.Extensions.DependencyInjection;

Core.Api.Testing/TestWebHostBuilder.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.IO;
-using Microsoft.AspNetCore.Hosting;
+using Microsoft.AspNetCore.Hosting;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 

Core.ElasticSearch/Config.cs

@@ -1,4 +1,3 @@
-using System;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Nest;

Core.ElasticSearch/Core.ElasticSearch.csproj

@@ -2,8 +2,6 @@
 
     <PropertyGroup>
         <TargetFramework>net6.0</TargetFramework>
-        <Nullable>enable</Nullable>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 
 
@@ -15,7 +13,6 @@
         <PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
     </ItemGroup>
 
-
     <ItemGroup>
       <ProjectReference Include="..\Core\Core.csproj" />
     </ItemGroup>

Core.ElasticSearch/Indices/IndexNameMapper.cs

@@ -1,6 +1,4 @@
-using System;
-using System.Collections.Concurrent;
-using System.Linq;
+using System.Collections.Concurrent;
 
 namespace Core.ElasticSearch.Indices;
 

Core.ElasticSearch/Projections/ElasticSearchProjection.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
-using Core.ElasticSearch.Indices;
+using Core.ElasticSearch.Indices;
 using Core.Events;
 using Core.Events.NoMediator;
 using Core.Projections;

Core.ElasticSearch/Repository/ElasticSearchRepository.cs

@@ -1,6 +1,3 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
 using Core.ElasticSearch.Indices;
 using Core.Events;
 using Nest;

Core.EventStoreDB/Core.EventStoreDB.csproj

@@ -2,8 +2,6 @@
 
     <PropertyGroup>
         <TargetFramework>net6.0</TargetFramework>
-        <Nullable>enable</Nullable>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 
 

Core.EventStoreDB/Events/AggregateStreamExtensions.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
-using Core.Events;
+using Core.Events;
 using Core.EventStoreDB.Serialization;
 using Core.Projections;
 using EventStore.Client;

Core.EventStoreDB/Events/StreamEventExtensions.cs

@@ -1,5 +1,4 @@
-using System;
-using Core.Events;
+using Core.Events;
 using Core.EventStoreDB.Serialization;
 using EventStore.Client;
 

Core.EventStoreDB/OptimisticConcurrency/StreamRevisionProviders.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Threading.Tasks;
-
-namespace Core.EventStoreDB.OptimisticConcurrency;
+namespace Core.EventStoreDB.OptimisticConcurrency;
 
 public class EventStoreDBOptimisticConcurrencyScope
 {

Core.EventStoreDB/Repository/EventStoreDBRepository.cs

@@ -1,9 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
-using Core.Aggregates;
+using Core.Aggregates;
 using Core.Events;
 using Core.EventStoreDB.Events;
 using Core.EventStoreDB.Serialization;

Core.EventStoreDB/Repository/RepositoryExtensions.cs

@@ -1,9 +1,5 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
 using Core.Aggregates;
 using Core.Exceptions;
-using MediatR;
 
 namespace Core.EventStoreDB.Repository;
 

Core.EventStoreDB/Subscriptions/EventStoreDBSubscriptionCheckpointRepository.cs

@@ -1,8 +1,4 @@
-using System;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
-using Core.Events;
+using Core.Events;
 using Core.EventStoreDB.Serialization;
 using EventStore.Client;
 

Core.EventStoreDB/Subscriptions/EventStoreDBSubscriptionToAll.cs

@@ -1,6 +1,3 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
 using Core.Events;
 using Core.Events.NoMediator;
 using Core.EventStoreDB.Events;

Core.EventStoreDB/Subscriptions/ISubscriptionCheckpointRepository.cs

@@ -1,7 +1,4 @@
-using System.Threading;
-using System.Threading.Tasks;
-
-namespace Core.EventStoreDB.Subscriptions;
+namespace Core.EventStoreDB.Subscriptions;
 
 public interface ISubscriptionCheckpointRepository
 {

Core.EventStoreDB/Subscriptions/InMemorySubscriptionCheckpointRepository.cs

@@ -1,6 +1,4 @@
 using System.Collections.Concurrent;
-using System.Threading;
-using System.Threading.Tasks;
 
 namespace Core.EventStoreDB.Subscriptions;
 

Core.Streaming.Kafka/Config.cs → Core.Kafka/Config.cs

@@ -1,16 +1,15 @@
 using Core.BackgroundWorkers;
 using Core.Events.External;
-using Core.Streaming.Kafka.Consumers;
-using Core.Streaming.Kafka.Producers;
+using Core.Kafka.Consumers;
+using Core.Kafka.Producers;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.DependencyInjection.Extensions;
 using Microsoft.Extensions.Logging;
 
-namespace Core.Streaming.Kafka;
+namespace Core.Kafka;
 
 public static class Config
 {
-
     public static IServiceCollection AddKafkaProducer(this IServiceCollection services)
     {
         //using TryAdd to support mocking, without that it won't be possible to override in tests

Core.Streaming.Kafka/Consumers/KafkaConsumer.cs → Core.Kafka/Consumers/KafkaConsumer.cs

@@ -1,6 +1,3 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
 using Confluent.Kafka;
 using Core.Events;
 using Core.Events.External;
@@ -11,7 +8,7 @@
 using Newtonsoft.Json;
 using IEventBus = Core.Events.IEventBus;
 
-namespace Core.Streaming.Kafka.Consumers;
+namespace Core.Kafka.Consumers;
 
 public class KafkaConsumer: IExternalEventConsumer
 {

Core.Streaming.Kafka/Consumers/KafkaConsumerConfig.cs → Core.Kafka/Consumers/KafkaConsumerConfig.cs

@@ -1,7 +1,7 @@
 using Confluent.Kafka;
 using Microsoft.Extensions.Configuration;
 
-namespace Core.Streaming.Kafka.Consumers;
+namespace Core.Kafka.Consumers;
 
 public class KafkaConsumerConfig
 {
@@ -17,4 +17,4 @@ public static KafkaConsumerConfig GetKafkaConsumerConfig(this IConfiguration con
     {
         return configuration.GetSection(DefaultConfigKey).Get<KafkaConsumerConfig>();
     }
-}
+}

Core.Streaming.Kafka/Core.Streaming.Kafka.csproj → Core.Kafka/Core.Kafka.csproj

@@ -2,8 +2,6 @@
 
     <PropertyGroup>
         <TargetFramework>net6.0</TargetFramework>
-        <Nullable>enable</Nullable>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 
     <ItemGroup>

Core.Streaming.Kafka/Producers/KafkaProducer.cs → Core.Kafka/Producers/KafkaProducer.cs

@@ -1,13 +1,10 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
 using Confluent.Kafka;
 using Core.Events;
 using Core.Events.External;
 using Microsoft.Extensions.Configuration;
 using Newtonsoft.Json;
 
-namespace Core.Streaming.Kafka.Producers;
+namespace Core.Kafka.Producers;
 
 public class KafkaProducer: IExternalEventProducer
 {

Core.Streaming.Kafka/Producers/KafkaProducerConfig.cs → Core.Kafka/Producers/KafkaProducerConfig.cs

@@ -1,7 +1,7 @@
 using Confluent.Kafka;
 using Microsoft.Extensions.Configuration;
 
-namespace Core.Streaming.Kafka.Producers;
+namespace Core.Kafka.Producers;
 
 public class KafkaProducerConfig
 {
@@ -17,4 +17,4 @@ public static KafkaProducerConfig GetKafkaProducerConfig(this IConfiguration con
     {
         return configuration.GetSection(DefaultConfigKey).Get<KafkaProducerConfig>();
     }
-}
+}

Core.Marten/Aggregates/AggregateExtensions.cs

@@ -1,5 +1,3 @@
-using System.Threading;
-using System.Threading.Tasks;
 using Core.Aggregates;
 using Core.Events;
 using Marten;

Core.Marten/Config.cs

@@ -1,5 +1,3 @@
-using System;
-using System.Threading;
 using Core.Ids;
 using Core.Marten.Ids;
 using Core.Marten.OptimisticConcurrency;

Core.Marten/Core.Marten.csproj

@@ -2,8 +2,6 @@
 
     <PropertyGroup>
         <TargetFramework>net6.0</TargetFramework>
-        <Nullable>enable</Nullable>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 
     <ItemGroup>

Core.Marten/ExternalProjections/MartenExternalProjection.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
-using Core.Events;
+using Core.Events;
 using Core.Events.NoMediator;
 using Core.Projections;
 using Marten;

Core.Marten/Ids/MartenIdGenerator.cs

@@ -1,4 +1,3 @@
-using System;
 using Core.Ids;
 using Marten;
 using Marten.Schema.Identity;

Core.Marten/OptimisticConcurrency/StreamVersionProviders.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Threading.Tasks;
-
-namespace Core.Marten.OptimisticConcurrency;
+namespace Core.Marten.OptimisticConcurrency;
 
 public class MartenOptimisticConcurrencyScope
 {

Core.Marten/Repository/MartenRepository.cs

@@ -1,6 +1,3 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
 using Core.Aggregates;
 using Core.Events;
 using Marten;

Core.Marten/Repository/RepositoryExtensions.cs

@@ -1,6 +1,3 @@
-using System;
-using System.Threading;
-using System.Threading.Tasks;
 using Core.Aggregates;
 using Core.Exceptions;
 

Core.Marten/Serialization/NonDefaultConstructorMartenJsonNetContractResolver.cs

@@ -1,5 +1,4 @@
-using System;
-using Core.Serialization.Newtonsoft;
+using Core.Serialization.Newtonsoft;
 using Marten;
 using Marten.Services.Json;
 using Newtonsoft.Json.Serialization;

Core.Serialization/Core.Serialization.csproj

@@ -2,8 +2,6 @@
 
     <PropertyGroup>
         <TargetFramework>net6.0</TargetFramework>
-        <ImplicitUsings>enable</ImplicitUsings>
-        <Nullable>enable</Nullable>
     </PropertyGroup>
 
     <ItemGroup>

Core.Testing/AggregateExtensions.cs

@@ -1,4 +1,3 @@
-using System.Linq;
 using Core.Aggregates;
 using Core.Events;