Removed obsolete IIS express run profiles.

Fixed async method signatures in tests. Fixed copy/paste naming issues in Cancel Shopping Carts API tests
oskardudycz · Mar 13, 2022 · 46570e5 · 46570e5
1 parent e5614f1
commit 46570e5
Show file tree

Hide file tree

Showing 33 changed files with 26 additions and 215 deletions.
diff --git a/CQRS.Tests/Queries/Queries.cs b/CQRS.Tests/Queries/Queries.cs
@@ -98,7 +98,7 @@ public Task<List<string>> Handle(GetIssuesNamesQuery query, CancellationToken ca
     }
 
     [Fact]
-    public async void GivenCommandWithData_WhenCommandIsSendToApplicationService_ThenreadModelIsChanged()
+    public async Task GivenCommandWithData_WhenCommandIsSendToApplicationService_ThenreadModelIsChanged()
     {
         var serviceLocator = new ServiceLocator();
 

diff --git a/MediatR.Tests/Publishing/MoreThanOneHandler.cs b/MediatR.Tests/Publishing/MoreThanOneHandler.cs
@@ -69,7 +69,7 @@ public MoreThanOneHandler()
     }
 
     [Fact]
-    public async void GivenTwoHandlersForOneEvent_WhenPublishMethodIsBeingCalled_ThenTwoHandlersAreBeingCalled()
+    public async Task GivenTwoHandlersForOneEvent_WhenPublishMethodIsBeingCalled_ThenTwoHandlersAreBeingCalled()
     {
         //Given
         var @event = new IssueCreated("cleaning");

diff --git a/MediatR.Tests/Publishing/NoHandlers.cs b/MediatR.Tests/Publishing/NoHandlers.cs
@@ -39,7 +39,7 @@ public IssueCreated(string issueName)
     }
 
     [Fact]
-    public async void GivenNonRegisteredQueryHandler_WhenPublishMethodIsBeingCalled_ThenThrowsAnError()
+    public async Task GivenNonRegisteredQueryHandler_WhenPublishMethodIsBeingCalled_ThenThrowsAnError()
     {
         var ex = await Record.ExceptionAsync(async () =>
         {

diff --git a/MediatR.Tests/Publishing/SingleHandler.cs b/MediatR.Tests/Publishing/SingleHandler.cs
@@ -70,7 +70,7 @@ public SingleHandler()
     }
 
     [Fact]
-    public async void GivenRegisteredAsynchronousRequestHandler_WhenPublishMethodIsBeingCalled_ThenReturnsProperResult()
+    public async Task GivenRegisteredAsynchronousRequestHandler_WhenPublishMethodIsBeingCalled_ThenReturnsProperResult()
     {
         //Given
         var @event = new IssueCreated("cleaning");

diff --git a/MediatR.Tests/Sending/MoreThanOneHandler.cs b/MediatR.Tests/Sending/MoreThanOneHandler.cs
@@ -70,7 +70,7 @@ public MoreThanOneHandler()
     }
 
     [Fact]
-    public async void GivenTwoHandlersForOneCommand_WhenSendMethodIsBeingCalled_ThenOnlyFIrstHandlersIsBeingCalled()
+    public async Task GivenTwoHandlersForOneCommand_WhenSendMethodIsBeingCalled_ThenOnlyFIrstHandlersIsBeingCalled()
     {
         //Given
         var query = new CreateIssueCommand("cleaning");

diff --git a/MediatR.Tests/Sending/NoHandlers.cs b/MediatR.Tests/Sending/NoHandlers.cs
@@ -39,7 +39,7 @@ public GetIssuesNamesQuery(string filter)
     }
 
     [Fact]
-    public async void GivenNonRegisteredQueryHandler_WhenSendMethodIsBeingCalled_ThenThrowsAnError()
+    public async Task GivenNonRegisteredQueryHandler_WhenSendMethodIsBeingCalled_ThenThrowsAnError()
     {
         var ex = await Record.ExceptionAsync(async () =>
         {

diff --git a/MediatR.Tests/Sending/SingleHandler.cs b/MediatR.Tests/Sending/SingleHandler.cs
@@ -71,7 +71,7 @@ public SingleHandler()
     }
 
     [Fact]
-    public async void GivenRegisteredAsynchronousRequestHandler_WhenSendMethodIsBeingCalled_ThenReturnsProperResult()
+    public async Task GivenRegisteredAsynchronousRequestHandler_WhenSendMethodIsBeingCalled_ThenReturnsProperResult()
     {
         //Given
         var query = new GetIssuesNamesQuery("cleaning");

diff --git a/Sample/AsyncProjections/SmartHome.Api/Properties/launchSettings.json b/Sample/AsyncProjections/SmartHome.Api/Properties/launchSettings.json
@@ -1,20 +1,5 @@
 {
-    "iisSettings": {
-        "windowsAuthentication": false,
-        "anonymousAuthentication": true,
-        "iisExpress": {
-            "applicationUrl": "http://localhost:38472",
-            "sslPort": 44357
-        }
-    },
     "profiles": {
-        "IIS Express": {
-            "commandName": "IISExpress",
-            "launchBrowser": true,
-            "environmentVariables": {
-                "ASPNETCORE_ENVIRONMENT": "Development"
-            }
-        },
         "SmartHomeApi": {
             "commandName": "Project",
             "launchBrowser": true,

diff --git a/Sample/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/AddingProduct/AddProductTests.cs b/Sample/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/AddingProduct/AddProductTests.cs
@@ -47,12 +47,10 @@ public AddProductTests(AddProductFixture fixture)
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public Task Put_Should_Return_OK()
+    public void Put_Should_Return_OK()
     {
         var commandResponse = fixture.CommandResponse.EnsureSuccessStatusCode();
         commandResponse.StatusCode.Should().Be(HttpStatusCode.OK);
-
-        return Task.CompletedTask;
     }
 
     [Fact]

diff --git a/Sample/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/Canceling/CancelShoppingCartTests.cs b/Sample/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/Canceling/CancelShoppingCartTests.cs
@@ -45,17 +45,15 @@ public ConfirmShoppingCartTests(ConfirmShoppingCartFixture fixture)
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public Task Put_Should_Return_OK()
+    public void Put_Should_Return_OK()
     {
         var commandResponse = fixture.CommandResponse.EnsureSuccessStatusCode();
         commandResponse.StatusCode.Should().Be(HttpStatusCode.OK);
-
-        return Task.CompletedTask;
     }
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public async Task Put_Should_Confirm_ShoppingCart()
+    public async Task Delete_Should_Cancel_ShoppingCart()
     {
         // prepare query
         var query = $"{fixture.ShoppingCartId}";

diff --git a/Sample/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/Confirming/ConfirmShoppingCartTests.cs b/Sample/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/Confirming/ConfirmShoppingCartTests.cs
@@ -46,17 +46,15 @@ public ConfirmShoppingCartTests(ConfirmShoppingCartFixture fixture)
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public Task Put_Should_Return_OK()
+    public void Put_Should_Return_OK()
     {
         var commandResponse = fixture.CommandResponse.EnsureSuccessStatusCode();
         commandResponse.StatusCode.Should().Be(HttpStatusCode.OK);
-
-        return Task.CompletedTask;
     }
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public async Task Put_Should_Confirm_ShoppingCart()
+    public async Task Delete_Should_Cancel_ShoppingCart()
     {
         // prepare query
         var query = $"{fixture.ShoppingCartId}";

diff --git a/Sample/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/RemovingProduct/RemoveProductTests.cs b/Sample/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/RemovingProduct/RemoveProductTests.cs
@@ -62,12 +62,10 @@ public RemoveProductTests(RemoveProductFixture fixture)
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public Task Delete_Should_Return_OK()
+    public void Delete_Should_Return_OK()
     {
         var commandResponse = fixture.CommandResponse.EnsureSuccessStatusCode();
         commandResponse.StatusCode.Should().Be(HttpStatusCode.NoContent);
-
-        return Task.CompletedTask;
     }
 
     [Fact]

diff --git a/Sample/ECommerce/Carts/Carts.Api/Properties/launchSettings.json b/Sample/ECommerce/Carts/Carts.Api/Properties/launchSettings.json
@@ -1,12 +1,4 @@
 {
-    "iisSettings": {
-        "windowsAuthentication": false,
-        "anonymousAuthentication": true,
-        "iisExpress": {
-            "applicationUrl": "http://localhost:38471",
-            "sslPort": 44357
-        }
-    },
     "profiles": {
         "CartsApi": {
             "commandName": "Project",

diff --git a/Sample/ECommerce/Orders/Orders.Api/Properties/launchSettings.json b/Sample/ECommerce/Orders/Orders.Api/Properties/launchSettings.json
@@ -1,12 +1,4 @@
 {
-    "iisSettings": {
-        "windowsAuthentication": false,
-        "anonymousAuthentication": true,
-        "iisExpress": {
-            "applicationUrl": "http://localhost:38471",
-            "sslPort": 44357
-        }
-    },
     "profiles": {
         "OrdersApi": {
             "commandName": "Project",

diff --git a/Sample/ECommerce/Orders/Orders/Orders/OrderSaga.cs b/Sample/ECommerce/Orders/Orders/Orders/OrderSaga.cs
@@ -74,9 +74,6 @@ public Task Handle(ProductWasOutOfStock @event, CancellationToken cancellationTo
 
     public Task Handle(OrderCancelled @event, CancellationToken cancellationToken)
     {
-        if (!@event.PaymentId.HasValue)
-            return Task.CompletedTask;
-
-        return commandBus.Send(DiscardPayment.Create(@event.PaymentId.Value));
+        return @event.PaymentId.HasValue ? commandBus.Send(DiscardPayment.Create(@event.PaymentId.Value)) : Task.CompletedTask;
     }
 }
diff --git a/Sample/ECommerce/Payments/Payments.Api/Properties/launchSettings.json b/Sample/ECommerce/Payments/Payments.Api/Properties/launchSettings.json
@@ -1,12 +1,4 @@
 {
-    "iisSettings": {
-        "windowsAuthentication": false,
-        "anonymousAuthentication": true,
-        "iisExpress": {
-            "applicationUrl": "http://localhost:38471",
-            "sslPort": 44357
-        }
-    },
     "profiles": {
         "PaymentsApi": {
             "commandName": "Project",

diff --git a/Sample/ECommerce/Shipments/Shipments.Api/Properties/launchSettings.json b/Sample/ECommerce/Shipments/Shipments.Api/Properties/launchSettings.json
@@ -1,12 +1,4 @@
 {
-    "iisSettings": {
-        "windowsAuthentication": false,
-        "anonymousAuthentication": true,
-        "iisExpress": {
-            "applicationUrl": "http://localhost:38471",
-            "sslPort": 44357
-        }
-    },
     "profiles": {
         "ShipmentsApi": {
             "commandName": "Project",

diff --git a/...entStoreDB/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/AddingProduct/AddProductTests.cs b/...entStoreDB/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/AddingProduct/AddProductTests.cs
@@ -46,12 +46,10 @@ public AddProductTests(AddProductFixture fixture)
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public Task Put_Should_Return_OK()
+    public void Put_Should_Return_OK()
     {
         var commandResponse = fixture.CommandResponse.EnsureSuccessStatusCode();
         commandResponse.StatusCode.Should().Be(HttpStatusCode.OK);
-
-        return Task.CompletedTask;
     }
 
     [Fact]

diff --git a/...toreDB/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/Canceling/CancelShoppingCartTests.cs b/...toreDB/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/Canceling/CancelShoppingCartTests.cs
@@ -43,17 +43,15 @@ public CancelShoppingCartTests(CancelShoppingCartFixture fixture)
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public Task Put_Should_Return_OK()
+    public void Put_Should_Return_OK()
     {
         var commandResponse = fixture.CommandResponse.EnsureSuccessStatusCode();
         commandResponse.StatusCode.Should().Be(HttpStatusCode.OK);
-
-        return Task.CompletedTask;
     }
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public async Task Put_Should_Confirm_ShoppingCart()
+    public async Task Delete_Should_Cancel_ShoppingCart()
     {
         // prepare query
         var query = $"{fixture.ShoppingCartId}";

diff --git a/...reDB/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/Confirming/ConfirmShoppingCartTests.cs b/...reDB/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/Confirming/ConfirmShoppingCartTests.cs
@@ -44,12 +44,10 @@ public ConfirmShoppingCartTests(ConfirmShoppingCartFixture fixture)
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public Task Put_Should_Return_OK()
+    public void Put_Should_Return_OK()
     {
         var commandResponse = fixture.CommandResponse.EnsureSuccessStatusCode();
         commandResponse.StatusCode.Should().Be(HttpStatusCode.OK);
-
-        return Task.CompletedTask;
     }
 
     [Fact]

diff --git a/...oreDB/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/RemovingProduct/RemoveProductTests.cs b/...oreDB/ECommerce/Carts/Carts.Api.Tests/ShoppingCarts/RemovingProduct/RemoveProductTests.cs
@@ -61,12 +61,10 @@ public RemoveProductTests(RemoveProductFixture fixture)
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public Task Delete_Should_Return_OK()
+    public void Delete_Should_Return_OK()
     {
         var commandResponse = fixture.CommandResponse.EnsureSuccessStatusCode();
         commandResponse.StatusCode.Should().Be(HttpStatusCode.NoContent);
-
-        return Task.CompletedTask;
     }
 
     [Fact]

diff --git a/Sample/EventStoreDB/ECommerce/Carts/Carts.Api/Properties/launchSettings.json b/Sample/EventStoreDB/ECommerce/Carts/Carts.Api/Properties/launchSettings.json
@@ -1,12 +1,4 @@
 {
-    "iisSettings": {
-        "windowsAuthentication": false,
-        "anonymousAuthentication": true,
-        "iisExpress": {
-            "applicationUrl": "http://localhost:38471",
-            "sslPort": 44357
-        }
-    },
     "profiles": {
         "CartsApi": {
             "commandName": "Project",

diff --git a/...le/EventStoreDB/Simple/ECommerce.Api.Tests/ShoppingCarts/AddingProduct/AddProductTests.cs b/...le/EventStoreDB/Simple/ECommerce.Api.Tests/ShoppingCarts/AddingProduct/AddProductTests.cs
@@ -46,12 +46,10 @@ public AddProductTests(AddProductFixture fixture)
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public Task Put_Should_Return_OK()
+    public void Put_Should_Return_OK()
     {
         var commandResponse = fixture.CommandResponse.EnsureSuccessStatusCode();
         commandResponse.StatusCode.Should().Be(HttpStatusCode.OK);
-
-        return Task.CompletedTask;
     }
 
     [Fact]

diff --git a/...ventStoreDB/Simple/ECommerce.Api.Tests/ShoppingCarts/Canceling/CancelShoppingCartTests.cs b/...ventStoreDB/Simple/ECommerce.Api.Tests/ShoppingCarts/Canceling/CancelShoppingCartTests.cs
@@ -43,17 +43,15 @@ public CancelShoppingCartTests(CancelShoppingCartFixture fixture)
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public Task Put_Should_Return_OK()
+    public void Put_Should_Return_OK()
     {
         var commandResponse = fixture.CommandResponse.EnsureSuccessStatusCode();
         commandResponse.StatusCode.Should().Be(HttpStatusCode.OK);
-
-        return Task.CompletedTask;
     }
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public async Task Put_Should_Confirm_ShoppingCart()
+    public async Task Delete_Should_Cancel_ShoppingCart()
     {
         // prepare query
         var query = $"{fixture.ShoppingCartId}";

diff --git a/...ntStoreDB/Simple/ECommerce.Api.Tests/ShoppingCarts/Confirming/ConfirmShoppingCartTests.cs b/...ntStoreDB/Simple/ECommerce.Api.Tests/ShoppingCarts/Confirming/ConfirmShoppingCartTests.cs
@@ -44,12 +44,10 @@ public ConfirmShoppingCartTests(ConfirmShoppingCartFixture fixture)
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public Task Put_Should_Return_OK()
+    public void Put_Should_Return_OK()
     {
         var commandResponse = fixture.CommandResponse.EnsureSuccessStatusCode();
         commandResponse.StatusCode.Should().Be(HttpStatusCode.OK);
-
-        return Task.CompletedTask;
     }
 
     [Fact]

diff --git a/...entStoreDB/Simple/ECommerce.Api.Tests/ShoppingCarts/RemovingProduct/RemoveProductTests.cs b/...entStoreDB/Simple/ECommerce.Api.Tests/ShoppingCarts/RemovingProduct/RemoveProductTests.cs
@@ -61,12 +61,10 @@ public RemoveProductTests(RemoveProductFixture fixture)
 
     [Fact]
     [Trait("Category", "Acceptance")]
-    public Task Delete_Should_Return_OK()
+    public void Delete_Should_Return_OK()
     {
         var commandResponse = fixture.CommandResponse.EnsureSuccessStatusCode();
         commandResponse.StatusCode.Should().Be(HttpStatusCode.NoContent);
-
-        return Task.CompletedTask;
     }
 
     [Fact]

diff --git a/Sample/EventStoreDB/Simple/ECommerce.Api/Properties/launchSettings.json b/Sample/EventStoreDB/Simple/ECommerce.Api/Properties/launchSettings.json
@@ -1,22 +1,6 @@
 {
   "$schema": "http://json.schemastore.org/launchsettings.json",
-  "iisSettings": {
-    "windowsAuthentication": false,
-    "anonymousAuthentication": true,
-    "iisExpress": {
-      "applicationUrl": "http://localhost:37117",
-      "sslPort": 44355
-    }
-  },
   "profiles": {
-    "IIS Express": {
-      "commandName": "IISExpress",
-      "launchBrowser": true,
-      "launchUrl": "swagger",
-      "environmentVariables": {
-        "ASPNETCORE_ENVIRONMENT": "Development"
-      }
-    },
     "ECommerce.Api": {
       "commandName": "Project",
       "dotnetRunMessages": "true",

diff --git a/Sample/MeetingsManagement/MeetingsManagement.Api/Properties/launchSettings.json b/Sample/MeetingsManagement/MeetingsManagement.Api/Properties/launchSettings.json
@@ -1,20 +1,5 @@
 {
-    "iisSettings": {
-        "windowsAuthentication": false,
-        "anonymousAuthentication": true,
-        "iisExpress": {
-            "applicationUrl": "http://localhost:38481",
-            "sslPort": 44357
-        }
-    },
     "profiles": {
-        "IIS Express": {
-            "commandName": "IISExpress",
-            "launchBrowser": true,
-            "environmentVariables": {
-                "ASPNETCORE_ENVIRONMENT": "Development"
-            }
-        },
         "MeetingsManagement.Api": {
             "commandName": "Project",
             "launchBrowser": true,