Fix issues with generics in extension services #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whiteboard implementation must create dynamic classes for each extension service to allow multiple instances of the same class to be registered. The existing generics handling was limited, and could not correctly represent unbound type variables, wildcards, nested generics, or reification of variables declared in super types. This commit enhances the generics processing in an attempt to cover all cases. Fixes osgi#39 Signed-off-by: Tim Ward <timothyjward@apache.org>
timothyjward
requested review from
juergen-albert
and removed request for
juergen-albert
|
Looks wild and I don't envy you for that bit of a struggle. Besides that it looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whiteboard implementation must create dynamic classes for each extension service to allow multiple instances of the same class to be registered. The existing generics handling was limited, and could not correctly represent unbound type variables, wildcards, nested generics, or reification of variables declared in super types. This commit enhances the generics processing in an attempt to cover all cases. Fixes #39