rf230_last_rssi is rssi value in dBm, fixed RF230_MIN_RX_POWER also i… #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mexx42
commented
Feb 29, 2020
| * else the rssi register is used having range 0 (91dBm) to 28 (-10dBm) | ||
| * For simplicity RF230_MIN_RX_POWER is based on the energy-detect value and divided by 3 when autoack is not set. | ||
| * else the rssi register is used having range 0 (-91dBm) to 28 (-10dBm) | ||
| * For simplicity RF230_MIN_RX_POWER i specified in dBm also and gets converted to the correct register values |
mexx42
commented
Feb 29, 2020
| @@ -667,7 +667,7 @@ ISR(TRX24_RX_START_vect) | |||
| // DEBUGFLOW('3'); | |||
| /* Save RSSI for this packet if not in extended mode, scaling to 1dB resolution */ | |||
| #if !RF230_CONF_AUTOACK | |||
| rf230_last_rssi = 3 * hal_subregister_read(SR_RSSI); | |||
| rf230_last_rssi = 90 - 3 * hal_subregister_read(SR_RSSI); | |||
There was a problem hiding this comment.
instead of using "90" we could use a define #RSSI_BASE_VAL - like in the chip specification
but where to put it ? in rf230bb.h ? is it common for all rf230 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes are also in other places where rssi gets print out which are not in our scope (e.g. ravenusb) - how to test ? - or should we simply ignore them ?
please review, tests, verify and merge into master ;)
regards,
m.