fix(email): fix case sensitivity in "Action" header retrieval #6663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a casing issue in the handling of the Action header while handling bounce notices from mail servers. Prior to this change, no emails could be flagged as a bounce email because the Upper-Case version of Action was used. This has been lowercases to "action". An accompanying unit test, tests that a bounce email is properly passed and it's attributes are setup. I have redacted a sample DSN email as much as I thought was necessary but am happy to re-review this fixture. As all other header access appears to be lowercase, this just appears to be a simple typo. This fixes: https://forum.osticket.com/d/104433-undelivered-mail-returned-to-sender-processing too
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a casing issue in the handling of the Action header while handling bounce notices from mail servers.
Prior to this change, no emails could be flagged as a bounce email because the Upper-Case version of Action was used. This has been lowercases to "action".
An accompanying unit test, tests that a bounce email is properly passed and it's attributes are setup. I have redacted a sample DSN email as much as I thought was necessary but am happy to re-review this fixture.
As all other header access appears to be lowercase, this just appears to be a simple typo.
This fixes: https://forum.osticket.com/d/104433-undelivered-mail-returned-to-sender-processing too
A huge thank you to: Hikari Akimori from the Resonite community for their sanity checks.