issue: Checkbox Template Variable #6648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an issue where when using a Checkbox on an Email Template the variable is replaced with `1` if checked and doesn't get replaced at all if unchecked. This is due to the `BooleanField` class not having an `asVar()` method so it uses the `FormField::asVar()` method which calls `to_php()`. This method returns an integer for BooleanField which is not what we want. This adds a new method called `asVar()` to the `BooleanField` class that calls `toString()` which will return `Yes` if checked and `No` if unchecked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where when using a Checkbox on an Email Template the variable is replaced with
1if checked and doesn't get replaced at all if unchecked. This is due to theBooleanFieldclass not having anasVar()method so it uses theFormField::asVar()method which callsto_php(). This method returns an integer for BooleanField which is not what we want. This adds a new method calledasVar()to theBooleanFieldclass that callstoString()which will returnYesif checked andNoif unchecked.