Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard hotkeys for ticket management #6644

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Adam7288
Copy link

In production use currently for 6 months, saves an enormous amount of time responding to customers.

@JediKev
Copy link
Contributor

JediKev commented Nov 30, 2023

@Adam7288

Thank you for the contribution. I would like to note that we are not accepting any new features to the current (legacy) codebase as we focus on the full codebase rewrite (v2.0). With this being said, we can definitely add this as a Feature Request for consideration after v2.0 so please stay tuned!

Cheers.

@Adam7288
Copy link
Author

Thanks would you need a new pull request at that time or just leave it?

@JediKev
Copy link
Contributor

JediKev commented Nov 30, 2023

@Adam7288

Being that v2.0 will be a complete rewrite it'll be a completely separate repo and codebase which will definitely need a new pull. Development will be a lot different in v2.0 so just stay tuned!

Cheers.

@Adam7288
Copy link
Author

Thanks - will do. God speed!

@nandi96
Copy link

nandi96 commented Dec 1, 2023

@JediKev when will be available the 2.0 RC?

@JediKev
Copy link
Contributor

JediKev commented Dec 1, 2023

@nandi96

We do not have a set release date as it’s still in development. With this being said we hope to have an RC/Preview next year. I will say that development is coming along really well! We are super excited and knocking a lot of things out. We will try to keep the community updated as much as possible as we make progress.

Cheers.

@JensEB
Copy link
Contributor

JensEB commented Dec 19, 2023

@Adam7288 nice feature.
But, if it's a pjax load, your short codes will not work in ticket list. To fix this bug, you have to disable the focus again after pjax load. I have modified your function to redisable the focus.
You can do this by following code in your hotkeys.js ...

//blur search field TODO have to figure out how to invoke on return from tickets -> listen for events
var blurSearchFieldFocus = function ( event ) {
    if($('input.basic-search').length && $('input.basic-search').is(':focus'))
            $('input.basic-search').blur();

    setTimeout(() => {

            if($('input.basic-search').length && $('input.basic-search').is(':focus'))
                    $('input.basic-search').blur();
    }, 500);
};
$(document).ready(function() {
    blurSearchFieldFocus();
});
$(document).on('pjax:end', function() {
    blurSearchFieldFocus();
});

Thanks for your work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants