issue: CDATA NULL Values #6583
Open
issue: CDATA NULL Values #6583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an issue reported on the Forum where `Has A Value` Queue criteria for a Short Answer field (and potentially other field types) is showing results without values. A recent patch causes empty values in the CDATA table to be `''` (empty string) instead of actual `NULL`. In SQL, `IS NOT NULL` checks against `NULL` explicitly. This means an empty string will appear with `IS NOT NULL` criteria as it's not NULL. This updates the code to only quote values that are not empty. Empty values should remain as `NULL`.
|
Need to update this as causing other errors. Waiting on confirmation of updated patch from Forum User. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue reported on the Forum where
Has A ValueQueue criteria for a Short Answer field (and potentially other field types) is showing results without values. A recent patch causes empty values in the CDATA table to be''(empty string) instead of actualNULL. In SQL,IS NOT NULLchecks againstNULLexplicitly. This means an empty string will appear withIS NOT NULLcriteria as it's not NULL. This updates the code to only quote values that are not empty. Empty values should remain asNULL.