fix: response handling for session store (bearer + cookie)

[till]

• Fix: response lost
• Chore: include tag/commit (instead of master)
• Fix: gzip handling

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #916 (9ea1270) into master (0b5f6e6) will decrease coverage by 12.22%.
The diff coverage is 25.00%.

❗ Current head 9ea1270 differs from pull request most recent head 4a4fd23. Consider uploading reports for the commit 4a4fd23 to get more accurate results

@@             Coverage Diff             @@
##           master     #916       +/-   ##
===========================================
- Coverage   77.87%   65.66%   -12.22%     
===========================================
  Files          80      104       +24     
  Lines        3924     4636      +712     
===========================================
- Hits         3056     3044       -12     
- Misses        589     1316      +727     
+ Partials      279      276        -3     

Impacted Files	Coverage Δ
pipeline/authn/authenticator_bearer_token.go	62.50% <0.00%> (-11.75%)	⬇️
pipeline/authn/authenticator_cookie_session.go	78.31% <33.33%> (-1.87%)	⬇️
rule/rule.go	74.13% <0.00%> (-6.10%)	⬇️
api/decision.go	91.11% <0.00%> (-4.45%)	⬇️
rule/rule_migrator.go	71.18% <0.00%> (-3.39%)	⬇️
pipeline/mutate/mutator_hydrator.go	65.09% <0.00%> (-2.74%)	⬇️
rule/fetcher_default.go	76.65% <0.00%> (-2.52%)	⬇️
metrics/prometheus.go	93.33% <0.00%> (-2.42%)	⬇️
credentials/fetcher_default.go	64.89% <0.00%> (-0.89%)	⬇️
... and 102 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[aeneasr]

Awesome, thank you for your contribution! This looks pretty good and I have some ideas how to improve it further :)

[till]

@aeneasr tried to address everything, let me know what you think.

[till]

@aeneasr we are relying on this to work, is it possible to get this integrated soon? As we are now having issues with websockets (see ory/network#76), it's getting messy to maintain this downstream. We'd also like to update of course.

[aeneasr]

Sorry for dropping the ball on this - I'm currently on my holidays but will try to find some time to review it :)

[till]

@aeneasr everything but lint works, when I run make format it changes all the markdown files. I hope you can fix that in another PR? I know you probably have tons on your plate, but I would really like to get this into the main branch so we can stop maintaining this? Any thoughts on how soon this is possible?

[aeneasr]

Hi @till - sorry that I missed your comment. If you resolve the conflicts with master everything should pass and we can take this for another review spin :)

[till]

@aeneasr seems like you implemented most of what we had (around preserving headers, settings, etc.) so this PR just adds test coverage for the original issue and fixes a bug where subject is not returned (where it is expected).