feat: add redirect to continue_with for SPA flows #3889
Conversation
This patch adds the new `continue_with` action `redirect_browser_to`, which contains the redirect URL the app should redirect to. It is only supported for SPA (not server-side browser apps, not native apps) flows at this point in time.
|
This is missing verification and recovery:
Also, I did not add tests for social sign in, because for social sign in we always use redirect-based flows, even for SPAs who react with 422 browser location change required, which in the end does a regular browser redirect with Since these are redirects I'm not sure if I covered all the cases everywhere. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3889 +/- ##
=======================================
Coverage 78.05% 78.06%
=======================================
Files 360 360
Lines 25241 25252 +11
=======================================
+ Hits 19703 19712 +9
- Misses 4032 4033 +1
- Partials 1506 1507 +1 ☔ View full report in Codecov by Sentry. |
|
I believe that these flows do not need continue_with transitions because they solve it differently (they show a success page where you click continue and end up on the redirect url). |
aeneasr
force-pushed
the
add-return-to
branch
4 times, most recently
from
9d4f6d6
to
fde4678
Compare
Using `OnLoadTrigger` and `OnClickTrigger` one can now map the trigger to the corresponding JavaScript function.
For example, trigger `{"on_click_trigger":"oryWebAuthnRegistration"}` should be translated to `window.oryWebAuthnRegistration()`:
```
if (attrs.onClickTrigger) {
window[attrs.onClickTrigger]()
}
```
This patch adds the new
continue_withactionredirect_browser_to, which contains the redirect URL the app should redirect to. It is only supported for SPA (not server-side browser apps, not native apps) flows at this point in time.Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments