chore: don't fail logout if cookie is not found

[jonas-jonas]

This should deflake the CRDB tests, that sometimes fail on master. From what I can tell, the issue is that the cookie can be removed due to other means, which then results in repeated calls to logout failing. Unfortunately, it's pretty difficult to debug, why the cookie is removed in the first place. I am also unsure, why this only happens on CRDB (pretty consistently on CI).

Related issue(s)

Checklist

• I have read the contributing guidelines.
• I have referenced an issue containing the design document if my change
  introduces a new feature.
• I am following the
  contributing code guidelines.
• I have read the security policy.
• I confirm that this pull request does not address a security
  vulnerability. If this pull request addresses a security vulnerability, I
  confirm that I got the approval (please contact
  security@ory.sh) from the maintainers to push
  the changes.
• I have added tests that prove my fix is effective or that my feature
  works.
• I have added or changed the documentation.

Further Comments

[jonas-jonas]

The end goal is to remove the cookie. If it doesn't exist in the first place, this action should not fail, IMO.

[zepatrik]

I am not sure I understand this, however it is fine by me to change the check as long as we have the assertion after login. Can you confirm that we assert the cookie after successful login?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.02%. Comparing base (386078e) to head (62d9709).
Report is 1 commits behind head on master.

❗ Current head 62d9709 differs from pull request most recent head b37e358. Consider uploading reports for the commit b37e358 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3871      +/-   ##
==========================================
+ Coverage   77.99%   78.02%   +0.02%     
==========================================
  Files         360      360              
  Lines       25198    25205       +7     
==========================================
+ Hits        19654    19665      +11     
+ Misses       4040     4035       -5     
- Partials     1504     1505       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.