Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log external latency #3868

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented Apr 11, 2024

With this change, we measure and log some external latency separately.

Right now, we consider this external:

  • OAuth2 provider APIs
  • webhooks

Other calls, like loading jsonnet or courier templates, are not considered external because they are tightly coupled to the server Kratos is running on.

@zepatrik zepatrik requested a review from alnr April 19, 2024 13:31
@zepatrik zepatrik marked this pull request as ready for review April 19, 2024 13:38
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 61.29032% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 78.08%. Comparing base (cc39f8d) to head (d5d5a49).
Report is 2 commits behind head on master.

Files Patch % Lines
selfservice/strategy/oidc/provider_lark.go 0.00% 5 Missing ⚠️
selfservice/strategy/oidc/provider_patreon.go 0.00% 4 Missing ⚠️
selfservice/strategy/oidc/provider_dingtalk.go 40.00% 3 Missing ⚠️
selfservice/strategy/oidc/provider_spotify.go 0.00% 3 Missing ⚠️
schema/handler.go 50.00% 1 Missing and 1 partial ⚠️
selfservice/strategy/oidc/provider_github.go 0.00% 2 Missing ⚠️
selfservice/strategy/oidc/provider_github_app.go 0.00% 2 Missing ⚠️
selfservice/strategy/oidc/provider_vk.go 66.66% 1 Missing ⚠️
selfservice/strategy/oidc/provider_x.go 0.00% 1 Missing ⚠️
selfservice/strategy/oidc/provider_yandex.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3868      +/-   ##
==========================================
+ Coverage   78.04%   78.08%   +0.04%     
==========================================
  Files         360      361       +1     
  Lines       25276    25274       -2     
==========================================
+ Hits        19726    19736      +10     
+ Misses       4038     4025      -13     
- Partials     1512     1513       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alnr alnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment.

selfservice/hook/web_hook.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants