Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update native recovery code flow docs #3806

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HerrSpeck
Copy link

I added more detailed information about the configuration required to get the native recovery code flow to work. Without a new feature flag, you will run into a "422 Browser location change required" error on your device. That means you won't be able to continue with the settings flow after the recovery flow was completed successfully, because native apps do not support browser redirects.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (0b32ce1) to head (6b640a7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3806   +/-   ##
=======================================
  Coverage   78.12%   78.12%           
=======================================
  Files         350      349    -1     
  Lines       24146    24124   -22     
=======================================
- Hits        18864    18848   -16     
+ Misses       3862     3855    -7     
- Partials     1420     1421    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WoodyWoodsta
Copy link

Are there any further details around use_continue_with_transitions feature flag? Does it affect any other flows, and are there any security considerations that we need to know about when enabling this? Is security reduced?

@jonas-jonas jonas-jonas changed the title docs: Update native recovery code flow docs docs: update native recovery code flow docs May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants