Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get additional user claims from Microsoft graph API #3722

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Jan 30, 2024

#3609 Introduced a bug where the subject could not be established from the GraphAPI response. This change fixes that, and also keeps the old way of querying the API as a fallback if anything goes wrong.

@alnr alnr requested a review from jonas-jonas January 30, 2024 13:51
@alnr alnr self-assigned this Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (84149c4) 78.33% compared to head (05734ed) 78.28%.
Report is 4 commits behind head on master.

Files Patch % Lines
selfservice/strategy/oidc/provider_microsoft.go 57.57% 7 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3722      +/-   ##
==========================================
- Coverage   78.33%   78.28%   -0.05%     
==========================================
  Files         347      347              
  Lines       23815    23831      +16     
==========================================
+ Hits        18655    18657       +2     
- Misses       3750     3760      +10     
- Partials     1410     1414       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant