Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upstream_parameters to oidc providers config #3644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

splaunov
Copy link
Contributor

While upstream parameters are already supported as part of a user request, sometimes there is a need to set them as a static values in a provider config.

Related issue(s)

#3138

Checklist

  • [x ] I have read the contributing guidelines.
  • [x ] I have referenced an issue containing the design document if my change
    introduces a new feature.
  • [x ] I am following the
    contributing code guidelines.
  • [x ] I have read the security policy.
  • [x ] I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • [x ] I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: Patch coverage is 29.41176% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 78.36%. Comparing base (5288bc7) to head (9bdd544).
Report is 1 commits behind head on master.

❗ Current head 9bdd544 differs from pull request most recent head 4e86e2f. Consider uploading reports for the commit 4e86e2f to get more accurate results

Files Patch % Lines
selfservice/strategy/oidc/provider_discord.go 0.00% 3 Missing ⚠️
selfservice/strategy/oidc/provider_patreon.go 0.00% 3 Missing ⚠️
selfservice/strategy/oidc/provider_apple.go 0.00% 2 Missing ⚠️
selfservice/strategy/oidc/provider_dingtalk.go 0.00% 2 Missing ⚠️
selfservice/strategy/oidc/provider_generic_oidc.go 75.00% 1 Missing and 1 partial ⚠️
selfservice/strategy/oidc/provider_github.go 0.00% 2 Missing ⚠️
selfservice/strategy/oidc/provider_github_app.go 0.00% 2 Missing ⚠️
selfservice/strategy/oidc/provider_google.go 60.00% 1 Missing and 1 partial ⚠️
selfservice/strategy/oidc/provider_lark.go 0.00% 2 Missing ⚠️
selfservice/strategy/oidc/provider_linkedin.go 0.00% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3644      +/-   ##
==========================================
+ Coverage   78.02%   78.36%   +0.33%     
==========================================
  Files         362      344      -18     
  Lines       25296    23516    -1780     
==========================================
- Hits        19737    18428    -1309     
+ Misses       4047     3699     -348     
+ Partials     1512     1389     -123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant