chore: update docusaurus to 3.X #1686
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Mar 24, 2024
…onToOwnFile' into jonas-jonas/updateDocusaurus
This comment was marked as outdated.
This comment was marked as outdated.
jonas-jonas
commented
Apr 24, 2024
| @@ -9,7 +9,6 @@ sidebar_label: Permissions | |||
| ```mdx-code-block | |||
| import CodeFromRemote from "@theme/CodeFromRemote" | |||
| import BrowserWindow from "@site/src/theme/BrowserWindow" | |||
| const file = (path) => `https://github.com/ory/keto/blob/master/contrib/rewrites-example/${path}` | |||
There was a problem hiding this comment.
You can't declare variables like this anymore: https://mdxjs.com/docs/troubleshooting-mdx/#unexpected-type-in-code-only-importexports-are-supported
| @@ -18,7 +18,6 @@ import { | |||
| } from "./code/registration" | |||
| import RenderFlow from "@site/src/theme/Code/RenderFlow" | |||
| import DomainWarning from "@site/src/theme/DomainWarning" | |||
| import AjaxWarning from "@site/src/theme/AjaxWarning" | |||
There was a problem hiding this comment.
Is now declared as a global component: https://github.com/ory/docs/pull/1686/files#diff-1a7d9fb0d0b87e2b0145fa0fa6599c217250db457fd1420801c2bcea6026c6f0R11
We can do that for the other commonly used custom components, and spare us the import statements.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments