Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update deploy-hydra-example.mdx #1685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreadistefano
Copy link

@andreadistefano andreadistefano commented Mar 20, 2024

Add server_name directive also in the listen 443 server block to deal with multiple virtual hosts.

I followed the guide on a local server I had lying around which already had nginx installed with some virtual hosts. (I know I should run it on a dedicated server but this is just a test environment).

I couldn't figure out why the provided nginx configuration was not working, until I realized that I needed to add the server_name directive also in the listen 443 server block, or nginx would serve content from a different virtual host.

I think the directive doesn't have any impact if the virtual host for Ory Hydra is the only one on the machine, but it's necessary if someone has other virtual hosts already configured.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Add `server_name` directive also in the listen 443 server block to deal with multiple virtual hosts
@CLAassistant
Copy link

CLAassistant commented Mar 20, 2024

CLA assistant check
All committers have signed the CLA.

@andreadistefano andreadistefano changed the title docs: Update deploy-hydra-example.mdx docs: update deploy-hydra-example.mdx Mar 20, 2024
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

Can you please add to the docs something that explains why server_name is needed? Also can you confirm that the set up still works on the default environment and doesn't break there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants