New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow using ory tunnel/proxy with project ID as well #311
base: master
Are you sure you want to change the base?
Conversation
I had to do a small refactor of naming to get access to some of the proxy configs from a different package I also added an interface to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
https://github.com/ory/cli/actions/runs/5455623971/jobs/9927330763?pr=311 tests fail with compile error |
seems to be golangci-lint complaining about something. will update |
I tried refreshing the snapshots locally with no change using |
0dc5f71
to
fe590fa
Compare
fe590fa
to
78fa786
Compare
96c5522
to
83e3ca3
Compare
Related Issue or Design Document
In the documentation we indicate that a user can spin up the tunnel/proxy using the project ID or the project slug.
The project ID is not currently supported and will show the user an error
The tunnel/proxy only takes the
--project
flag and does string manipulation to add the project slug into the ory api string.https://www.ory.sh/docs/getting-started/local-development#local-development
Checklist
and signed the CLA.
introduces a new feature.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
appropriate).
Further comments