Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification recipients list is not as expected #997

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vytsci
Copy link

@vytsci vytsci commented Mar 24, 2020

We have encountered a bug, where doctrine metadata wont lazy load relations and in that case our notification recipients list is not as expected. Lots of users have not received their email because of this bug, it is maybe a Doctrine issue, but im adding PR just in case for someone with same bug.

When we use property accessor then we basically use getters and all the relations will be lazy loaded.

We have encountered a bug, where doctrine metadata wont lazy load relations and in that case our notification recipients list is not as expected. Lots of users have not received their email because of this bug, it is maybe a Doctrine issue, but im adding PR just in case for someone with same bug.

When we use property accessor then we basically use getters and all the relations will be lazy loaded.
@anyt
Copy link
Contributor

anyt commented Mar 24, 2020

Hi @vytsci,
Can you describe steps to reproduce the issue with not received email?

@vytsci
Copy link
Author

vytsci commented Mar 24, 2020

Yes, Oro version is 3.1.19 and Doctrine ORM 2.6.3, create workflow transition notification rule and add contact group that is association field.
image
And Doctine wont lazy load this association, this recipient will be ignored because getAssociationValue returns null. This is only a suggestion fix, but if I use property accessor seems like issue is solved as property accessor uses getters to retrieve values, and getters triggers lazy load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants