Disable the validation of segment filter form #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Uladzimir, Thank you for the interesting idea, we'll investigate this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
All oro filters (like datetime, string and other) uses symfony forms for transforming filter data from user input input data. All default entity validator will be trigger, if filter form data contains the entity. Oro segments are also was implemented via a filter model. So when we use segments, all validators for segment entity will be trigger again and again.
https://github.com/oroinc/platform/blob/master/src/Oro/Bundle/SegmentBundle/Resources/config/validation.yml#L1-L8
It leads to duplicate sql queries and performance degradation
Fixed #925