Fix for email addresses with accented and non-ASCII characters (IMAP sync) #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… IMAP sync Occasionally during IMAP sync the email address is received with foreign non-ASCII characters which are in PHP treated separately from purely ASCII ones. This later creates SQL Unique violation as it is flushed into database, where it's treated identically as ASCII characters. For example: - émáil@example.com - email@example.com is added to addresses under different key during IMAP sync. However during flush to database both above addresses are treated as 'email@example.com', so it triggers MySQL error with `oro_email_address_uq` constraint. This converts it to use only ASCII characters for email.
|
Thank you for your pull request. It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocrm.com/contributor-license-agreement/ If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits. Once you've signed the CLA, please allow for some time for the submission to be processed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally during IMAP sync the email address is received with foreign non-ASCII characters
which are in PHP treated separately from purely ASCII ones. This later creates SQL Unique violation
as it is flushed into database, where it's treated identically as ASCII characters.
For example:
is added to addresses under different key during IMAP sync. However during flush to database both
above addresses are treated as 'email@example.com', so it triggers MySQL error with
oro_email_address_uqconstraint.This converts it to use only ASCII characters for email.