Oro ignore-tabbable.js breaks default tab to focus behaviour #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimohalloran
force-pushed
the
ignore_tabbable_fix_1061
branch
from
6d63183
to
eef8af4
Compare
|
Thank you for your contribution, @jimohalloran. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a simple fix for #1061. Currently when ignore-tabbable.js switches focus to a new element, the contents of the new element is not highlighted breaking the default web browser behaviour.
This PR checked to see if the element just focused has a "select" method, and if so calls it to select the contents of the newly focused element. Select boxes and buttons don't have a selection and therefore we shouldn't just blindly call
select()on everything.