Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Enable automatic signing in xcode for debug #8117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rtsisyk
Copy link
Contributor

@rtsisyk rtsisyk commented May 7, 2024

Automatic signing works out of the box without any manual intervention. iCloud entitlement works in this mode. CarPlay wasn't tested.

Automatic signing works out of the box without any manual intervention.
iCloud entitlement works in this mode. CarPlay wasn't tested.

Signed-off-by: Roman Tsisyk <roman@tsisyk.com>
@rtsisyk rtsisyk requested a review from kirylkaveryn May 7, 2024 12:29
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can anyone test it and confirm that it works out of the box?

@@ -4658,7 +4658,7 @@
MARKETING_VERSION = 2022.11.17;
OTHER_SWIFT_FLAGS = "$(inherited)";
PRODUCT_BUNDLE_IDENTIFIER = app.organicmaps.debug;
PROVISIONING_PROFILE_SPECIFIER = "CarPlay Debug";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not right. Will debug builds run on CarPlay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the description of the PR, I haven't tested CarPlay. However, iCloud also requires entitlements and it works well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand why this line has been removed. It is required to work with CarPlay in Debug.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biodranik He removed it because of this warning:

Screenshot 2024-05-13 at 16 04 57

Anyway, I tested CarPlay with auto signing and it worked even without this line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks for the update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about

4683:				PROVISIONING_PROFILE_SPECIFIER = "CarPlay Release";

?

Should it also be removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release is still on manual signing so I don't think we can remove this line there.

Copy link
Contributor

@fabwu fabwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic singing works on my Mac with CarPlay.

@rtsisyk
Copy link
Contributor Author

rtsisyk commented May 16, 2024

Automatic singing works on my Mac with CarPlay.

Thanks, @fabwu . @kirylkaveryn could you please test also?

@kirylkaveryn
Copy link
Contributor

Automatic singing works on my Mac with CarPlay.

Thanks, @fabwu . @kirylkaveryn could you please test also?

@rtsisyk
For me it is also works well with the autosigning for carplay - builds and runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants