[WIP] Added text to speech instructions #171
Conversation
meenbeese
force-pushed
the
tts-instructions
branch
2 times, most recently
from
0720eb0
to
6ee4708
Compare
|
Html file in shortcodes doesn't look right. How it should be translated? Let's create a faq section first, and add it into the top menu. |
I agree with you. The reason I went with html is because I kept getting weird errors with markdown that I couldn’t resolve and html was much easier to work with.
This makes a lot of sense. In that case, should I incorporate the work from #115 into this PR too? There is no need to duplicate all that work that was already done. |
|
What kind of weird errors did you get with markdown? Yes, you can incorporate changes from that pr. But we need a separate section, not a single FAQ page. See #6 |
I get this error when trying to call the screenshots function from markdown: And when I remove the function call to integrate them directly into md, they don't render at all.
You mean like adding it to the top bar, right? If so, I will start working on that now. Do you have an idea of where it would be best to add it? Before the news, or after Github for example? |
|
Never mind the previous errors as I figured out how to implement it using HTML. The only thing needed now is the taxonomy you mentioned previously in a linked issue so that every FAQ question has its own markdown file. Then, it will be easier to add several different FAQ titles, translate them and link them from the main app as necessary.
|
meenbeese
temporarily deployed
to
production
GitHub Actions
Inactive
meenbeese
temporarily deployed
to
production
GitHub Actions
Inactive
meenbeese
force-pushed
the
tts-instructions
branch
from
6f2d5c6
to
0d268f2
Compare
meenbeese
temporarily deployed
to
production
GitHub Actions
Inactive
meenbeese
temporarily deployed
to
production
GitHub Actions
Inactive
meenbeese
force-pushed
the
tts-instructions
branch
from
a823542
to
5c7aeaf
Compare
meenbeese
temporarily deployed
to
production
GitHub Actions
Inactive
meenbeese
temporarily deployed
to
production
GitHub Actions
Inactive
meenbeese
force-pushed
the
tts-instructions
branch
from
f6b0662
to
1e74116
Compare
meenbeese
temporarily deployed
to
production
GitHub Actions
Inactive
I agree, a preview would be nice. How can I do this? |
| install-appgallery = "Install Organic Maps from Huawei AppGallery" | ||
| install-appstore = "Install Organic Maps from the AppStore" | ||
| install-googleplay = "Install Organic Maps from Google Play" | ||
| install-fdroid="Install Organic Maps from F-Droid" | ||
| language = "English" | ||
| const_lang = "Language" |
There was a problem hiding this comment.
Is there a better way to name this?
meenbeese
force-pushed
the
tts-instructions
branch
from
1e74116
to
45de45e
Compare
meenbeese
temporarily deployed
to
production
GitHub Actions
Inactive
|
|
||
| | | | | | ||
| | ----------- | ----------- | ----------- | | ||
| | <img src='/images/screenshots/tts_config_1.jpg' width='400' alt='Screenshot 1'> | <img src='/images/screenshots/tts_config_2.jpg' width='400' alt='Screenshot 2'> | <img src='/images/screenshots/tts_config_3.jpg' width='400' alt='Screenshot 3'> | |
There was a problem hiding this comment.
These alt tags are not useful at all. Please a more descriptive text.
Signed-off-by: meenbeese <meenbeese@tutanota.com> Create text-to-speech.md Signed-off-by: meenbeese <meenbeese@tutanota.com> Update text-to-speech.md Signed-off-by: meenbeese <meenbeese@tutanota.com> Add files via upload Signed-off-by: meenbeese <meenbeese@tutanota.com> Update text-to-speech.md Signed-off-by: meenbeese <meenbeese@tutanota.com> Added LineageOS instructions for tts Signed-off-by: meenbeese <meenbeese@tutanota.com> Made small changes Signed-off-by: meenbeese <meenbeese@tutanota.com> Update text-to-speech.md Signed-off-by: meenbeese <meenbeese@tutanota.com> [WIP] Added text to speech instructions Signed-off-by: meenbeese <meenbeese@tutanota.com> Add faq to top bar and use md Signed-off-by: meenbeese <meenbeese@tutanota.com> Minor rewording and grammar fixes Signed-off-by: meenbeese <meenbeese@tutanota.com> Add table with all languages Signed-off-by: meenbeese <meenbeese@tutanota.com> Update eSpeak link Signed-off-by: meenbeese <meenbeese@tutanota.com> Update and clarify instructions page Signed-off-by: meenbeese <meenbeese@tutanota.com>
meenbeese
force-pushed
the
tts-instructions
branch
from
45de45e
to
4b0ee3f
Compare
Revives the TTS PR by improving upon it. The current solution that I managed to implement is not final and should be iterated before merging. The FAQ living in the main page is not ideal because it should be in the header bar and in its own page instead so it can be linked easily from the main app.
I know that this is a PR that stalled for too long and is important for many issues to be resolved in Organic Maps. Can you take a look so we can discuss/make the necessary improvements and merge it as soon as possible @biodranik ?
Closes #6
Closes #32
Closes #115