Updated protobuf to 4.24.4 #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biodranik
force-pushed
the
ab-protobuf
branch
from
8a46272
to
5a31a2a
Compare
pastk
approved these changes
Oct 15, 2023
README.md
Outdated
| @@ -7,3 +7,5 @@ Python dependencies: | |||
| ```bash | |||
| pip3 install -r requirements.txt | |||
| ``` | |||
|
|
|||
| Updating protobuf in the repo should be synced with Kothik. | |||
There was a problem hiding this comment.
Suggested change
| Updating protobuf in the repo should be synced with Kothik. | |
| Updating protobuf in the repo should be synced with Kothic. |
Signed-off-by: Alexander Borsuk <me@alex.bio>
biodranik
force-pushed
the
ab-protobuf
branch
from
5a31a2a
to
2260f36
Compare
|
@pastk regenerating drules with newer protobuf from this branch doesn't show any local changes. Is it expected? |
|
Looks like the binary format didn't change (at least in the part used by us). |
|
@AndrewShkrob There is a Probably all scripts should be changed to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pastk