Compatibility with latest org-id version: advise org-id-find rather than overwriting id link

[ricklupton]

Motivation for this change

There have been recent changes in org-mode to improve org-id-open to be able to apply search strings in id: links. But, org-roam overrides the :follow parameter for id: links to its own org-roam-id-open function and therefore misses this.

The only change that org-roam-id-open makes is to try calling org-roam-id-find before falling back on org-id-find. This commit uses advice to do this directly, thereby integrating better with org-id-open.

There was some discussion on the org-mode list about adding a custom variable to avoid using advice, but this accomplishes the result without requiring changes in org:

https://list.orgmode.org/87jzlxjiuf.fsf@localhost/

[akashpal-21]

Interesting - I had this functionality by simply using an advice function over both org-id-open and org-roam-id-open.
Commenting to keep track if this gets pushed - my code will become obsolete.

(defun org-id-open--support-search (fn link &rest args)
  "Support ::SEARCH syntax for id: links."
  ;; Save match data to prevent modifications by string matching functions.
  (save-match-data
    ;; Split the link at the '::' delimiter.
    (let* ((parts (split-string link "::"))  ; Split the link into parts.
	   (id (car parts))                  ; Extract the ID part.
	   (search (cadr parts)))            ; Extract the search part.
      ;; Execute the original function and perform search operations.
      (prog1 (funcall fn id args)
	;; Conditionally execute additional actions based on the search part.
	     (cond ((null search))                                   ; Do nothing if search part is null.
		   ((string-match-p "\\`[0-9]+\\'" search)           ; If search part is a number.
		    (forward-line (string-to-number search)))        ; Move N lines after the ID.
		   ((string-match "^/\\([^/]+\\)/$" search)          ; If search part is a regex match.
		    (let ((match (match-string 1 search)))           ; Extract the match string.
		      (save-excursion (org-link-search search))      ; Search for the match.
		      (when (re-search-forward match)                ; When match is found.
			(goto-char (match-beginning 0)))))           ; Move point to the match.
		   ((org-link-search search)))))))                   ; Otherwise, perform org-link-search.
;; Add Advice around id open functions
(advice-add 'org-id-open :around #'org-id-open--support-search)
(advice-add 'org-roam-id-open :around #'org-id-open--support-search)