Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add an abnormal hook for org-roam-extract-subtree #182 #2366

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jmay
Copy link
Contributor

@jmay jmay commented Jul 18, 2023

#2365

Refactoring: extracted pieces of org-roam-extract-subtree to utility functions.
Added a defcustom for the hook (abnormal hook, takes a parameter). Default is an empty hook, so no change in standard behavior.

For consideration: include 2 sample hook functions, unused by default: one to insert a link to the extracted node, one to insert a #+transclude: line.

@jmay
Copy link
Contributor Author

jmay commented Jul 21, 2023

Hey @jethrokuan can you see why this test case fails under emacs 27? I haven't use buttercup before, I'm probably relying on some behavior that doesn't exist in older emacsen.

Also for the new test file test-org-roam-extract.el I just replicated the file header from the other tests. Not sure if that's the correct practice, I don't want to invoke your name in there without an OK from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant