(feat)capture: add customizable defaults for deleting aborted files #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* org-roam-capture.el (org-roam-capture-delete-aborted-files): new custom var (org-roam-capture--check-aborted-delete): util function to check whether we should delete the file after an aborted capture. (org-roam-capture--finalize): use `org-roam-capture--check-aborted-delete' rather than `yes-or-no-p'.
Hugo-Heagren
force-pushed
the
customize-aborted-files
branch
from
091e893
to
4fc6174
Compare
|
Just stumbled over the very same problem. What's keeping this PR from progressing? |
See #2375. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom var
(org-roam-capture--check-aborted-delete): util function to check
whether we should delete the file after an aborted capture.
(org-roam-capture--finalize): use
org-roam-capture--check-aborted-delete' rather thanyes-or-no-p'.Motivation for this change
I abort captures pretty regularly but I always answer the same to the prompt which asks whether I want to delete the aborted file -- I always want to delete it. This is a (tiny) friction which could be easily customised away. This PR makes that possible.