(fix) Replace olp with heading list #2336
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Closes #2335
After
org-roam-capture--fill-template
which actually calls(kill-buffer)
inside it, strangelykill-buffer
reverts buffer position from(point-min)
to original. Sore-search-forward
loop can't find headings correct andorg-roam-capture-find-or-create-olp
keep creating headings if the buffer is already visited and buffer position is under below the OLP.So I change
olp
to(setq headings (mapcar #'org-roam-capture--fill-template olp))
then use it in the search loop.After this patch, below test code doesn't make new "Tasks" heading again when it exists already.