Update camera.py #22
Update camera.py #22
Conversation
fix exception handling when camera isn't found so program does not crash
There was a problem hiding this comment.
An extra level of complexity is the kernel module wont be loaded until after ~20 seconds after boot as the PRUs must exist before the module is loaded.
This or the service that uses an object of this class will need to handle it the fact the camera will not be found at the start of the app, but should be found / accessible later on.
Also run black and isort to pass the workflow.
| return value | ||
| with open(f"{context_path}/{name}", "r") as f: | ||
| value = int(f.read()) | ||
| return value |
There was a problem hiding this comment.
don't return inside of a with block
There was a problem hiding this comment.
Why not? It'll do the right thing, the resource will be cleaned up (the file closed) no matter how you leave the block, return included. Returning inside a with block is even called out in the relevant PEP as a reason why you'd want to use it.
|
Closing in favor of #23 |
fix exception handling when camera isn't found so program does not crash