Run compiled binary on Lichee #708
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #708 +/- ##
=====================================
Coverage 1.57% 1.57%
=====================================
Files 22 22
Lines 954 954
=====================================
Hits 15 15
Misses 939 939 |
orangecms
reviewed
Aug 20, 2023
| @@ -12,6 +12,10 @@ XFEL ?= xfel | |||
| MEMADDR ?= 0x40000000 | |||
| RELEASE ?= --release | |||
|
|
|||
| MODE ?= release | |||
There was a problem hiding this comment.
this should be in sync with RELEASE (see above)
How do you feel about putting this into xtask instead? Currently it's a mix already, and gotten messy.
There was a problem hiding this comment.
Thanks for the feedback. I'll have a look into xtask and will try to implement that next week
There was a problem hiding this comment.
xtask at first looks hard, but you will be happy if you go for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I created this make command together with @orangecms . Someone might find it useful to run the compiled sources on the Lichee. You need to have a usable "xfel" binary in your path for that :)