[WIP] Support Qemu RISC-V virt tagret #703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #703 +/- ##
========================================
- Coverage 1.57% 1.56% -0.01%
========================================
Files 22 23 +1
Lines 954 959 +5
========================================
Hits 15 15
- Misses 939 944 +5
|
/src/mainboard/emulation/qemu-riscv/src/{init.S, bootblock.S} are never
used anywhere. The fix was to use them in main.rs using global_asm!.
bootblock.S contains entry point code for the whole rom, while init.S
contains some symbols used by bootblock.S
Signed-off-by: Ahmed <ahmedsoliman@oddcoder.com>
The correct address according to qemu + gdb is 0x80000000 Tested using Qemu version 8.0.3 Steps to reproduce the address in one tab run: qemu-system-riscv64 -m 4g -machine virt -nographic -bios /home/oddcoder/projects/VisionFive2/oreboot/target/riscv64imac-unknown-none-elf/release/emulation-qemu-riscv-bootblob.bin -s -S in another tab attach gdb PC will be initialized at 0x1000 but that code is not our bios code, perhaps qemu's first stage bootloader? but it looks like this: 0x1000: auipc t0,0x0 0x1004: add a2,t0,40 0x1008: csrr a0,mhartid 0x100c: ld a1,32(t0) 0x1010: ld t0,24(t0) 0x1014: jr t0 at the end of this code, t0 is initialized to 0x80000000 and we jump into it, and that is our bootrom Signed-off-by: Ahmed <ahmedsoliman@oddcoder.com>
This Ld script fails to work once the code starts improting symbols. problems is we selectively keep some symbols and selectively get rid of others and it feels arbitrary. I just replaced the whole meat of the while with structure equivalent to that of link-nezha-bt0.ld. The errors are generated arbitrarily and it is very hard to give a solidc case where errors can be reproduced. Signed-off-by: Ahmed <ahmedsoliman@oddcoder.com>
Signed-off-by: Ahmed <ahmedsoliman@oddcoder.com>
Signed-off-by: Ahmed <ahmedsoliman@oddcoder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.