Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sipeed/m1s-dock: bootstrap board #659

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

orangecms
Copy link
Contributor

Signed-off-by: Daniel Maslowski info@orangecms.org

Copy link
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's been almost 4 years since we started this project, and I'm starting to feel like the code is converging to a nice new place. This is nice.

Copy link
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you need all of main to be unsafe?

@orangecms orangecms mentioned this pull request Jan 22, 2023
@orangecms orangecms force-pushed the oreboot-bl808 branch 3 times, most recently from e58f909 to 9609fa4 Compare January 22, 2023 20:56
@orangecms
Copy link
Contributor Author

if you need all of main to be unsafe?

no longer with a fixup in the PAC crate; PR pending: bouffalolab/bl808-pac#5

@orangecms
Copy link
Contributor Author

and with today's changes, both cores are running now (note: heterogeneous - 32bit and 64bit!) :)

This is external code, so no point for us to check it with our rules.
It currently raises an error in edk2, so ignore it.

Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
This is the result of some whack-a-mole with lifetems, dyn, traits, mut,
etc etc. Unfortunately, this now introduces an allocator.
Someone please figure out a more elegant way. All I wanted was to have
an abstract logger that can be moved out into a crate again.

Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
For now, switch to a forked and patch bl808-pac. PR pending:
bouffalolab/bl808-pac#5

Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
Signed-off-by: Daniel Maslowski <info@orangecms.org>
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #659 (9230565) into main (408b431) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #659      +/-   ##
========================================
- Coverage   0.21%   0.20%   -0.01%     
========================================
  Files         22      23       +1     
  Lines        939     972      +33     
========================================
  Hits           2       2              
- Misses       937     970      +33     
Files Coverage Δ
src/mainboard/sipeed/m1s-dock/e907/src/uart.rs 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants