BugFix Trait AsSource

[ivanomatteo]

The trait is part of the model class, so can access also to private and protected members.
For example if we use this trait on a model with a nullable database field called "visible"

Arr::get($this->toArray(), $field) ---> is null
Arr::get($this->getRelations(), $field) ---> is null
$this->$field ---> refear to "protected $visible = []"

with this commit the problem is solved, and anso bring a performance improvement:
->toArray() force the execution of all casts and accessors, but only one filed is requested.

[tabuna]

These lines will break the usual behavior that users are accustomed to. For example with access to private properties to be prohibited, it was enough to change only
the call to $this->$field to$this->getAttribute($field)

[ivanomatteo]

Ok, do you mean when passing $field === null?

in that case just prepend:

if($field === null){
return $this->toArray();
}

It’s unnecessary serialize all fields to get just one.

Also public class property can override database fields with the current code.
But using getAttribute() it will not happen anymore:
Is the right behavior?
Or do you think it’s a breaking change?

[tabuna]

I mean, for solution #1989 it is enough to change the call to getAttribute.
Other changes do not affect issue #1989. Plus, they break current tests (and existing user code.)

platform/tests/Unit/Screen/SourceTest.php

Lines 67 to 91 in 39d631a

	public function testGetSimpleAttribute(): void
	{
	$this->assertEquals(8, $this->model->getContent('id'));
	$this->assertEquals('Alexandr Chernyaev', $this->model->getContent('name'));
	$this->assertEquals('red', $this->model->getContent('color'));
	}
	public function testGetArrayAttribute(): void
	{
	$this->assertIsArray($this->model->getContent('options.country'));
	$this->assertContains('Russia', $this->model->getContent('options.country'));
	$this->assertIsBool($this->model->getContent('options.skills.php'));
	$this->assertTrue($this->model->getContent('options.skills.php'));
	}
	public function testGetRelation(): void
	{
	$this->assertIsInt($this->model->getContent('many.three'));
	$this->assertEquals(84, $this->model->getContent('many.three'));
	$this->assertContains('one', $this->model->getContent('many'));
	$this->assertContains('two', $this->model->getContent('many'));
	$this->assertEquals('one', $this->model->getContent('many')[0]);
	}

[ivanomatteo]

Oh, I see, it must support dot notation.