Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OHRM5X-1987 : Test Automation : Admin - Education, Language #1595

Open
wants to merge 2 commits into
base: 5.4
Choose a base branch
from

Conversation

DasuniPathiraje
Copy link

No description provided.

cy.get('.orangehrm-horizontal-padding > .oxd-text').contains(
'(1) Record Found',
);
cy.get('[style="flex-basis: 80%;"] > div').contains(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using style is not the best way to select here. is this for table column?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is to get the level name from the table

cy.get('.orangehrm-horizontal-padding > .oxd-text').contains(
'(2) Records Found',
);
cy.task('db:snapshot', {name: 'education2'});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a more descriptive name for this snapshot?

cy.get('.orangehrm-horizontal-padding > .oxd-text').contains(
'(1) Record Found',
);
cy.get('[style="flex-basis: 80%;"] > div').contains(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the selector here also

beforeEach(function () {
cy.task('db:reset');
cy.fixture('chars').as('strings');
//cy.intercept('GET', '**/api/v2/admin/languages?*').as('getLanguage');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants