-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OHRM5X-1987 : Test Automation : Admin - Education, Language #1595
base: 5.4
Are you sure you want to change the base?
Conversation
cy.get('.orangehrm-horizontal-padding > .oxd-text').contains( | ||
'(1) Record Found', | ||
); | ||
cy.get('[style="flex-basis: 80%;"] > div').contains( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using style is not the best way to select here. is this for table column?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is to get the level name from the table
cy.get('.orangehrm-horizontal-padding > .oxd-text').contains( | ||
'(2) Records Found', | ||
); | ||
cy.task('db:snapshot', {name: 'education2'}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a more descriptive name for this snapshot?
cy.get('.orangehrm-horizontal-padding > .oxd-text').contains( | ||
'(1) Record Found', | ||
); | ||
cy.get('[style="flex-basis: 80%;"] > div').contains( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change the selector here also
beforeEach(function () { | ||
cy.task('db:reset'); | ||
cy.fixture('chars').as('strings'); | ||
//cy.intercept('GET', '**/api/v2/admin/languages?*').as('getLanguage'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented code
No description provided.