Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

Add option init-container #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alantang888
Copy link

For #242 I try to add an init container to sleep 20 seconds before start mysql. Then the problem not happen again. So I add option to add init-container.

Copy link

@prydie prydie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @alantang888 - nice work 👍!

You'll need to sign the Oracle Contributor Agreement so we can merge your changes. Do let me know if you've already done so and I'll chase internally to get it processed.

Makefile Outdated Show resolved Hide resolved
@prydie prydie added enhancement oracle-cla: no Contributor has not yet signed the Oracle Contributor Licence Agreement labels Dec 15, 2018
@alantang888
Copy link
Author

Hi @prydie I just sent the signed Oracle Contributor Agreement. Since I don't have scanner. So I only can use my phone to take photo for agreement. Thanks a lot.

@alantang888
Copy link
Author

alantang888 commented Dec 17, 2018

Hi @prydie the Oracle Contributor Agreement is completed. And updated the commit sign off email.

But I don't know why the end-to-end test MySQL Upgrade part failed...

Signed-off-by: Alan Tang <alantang888@gmail.com>
@alantang888
Copy link
Author

Hello?

@prydie
Copy link

prydie commented Jan 8, 2019

Hi @alantang888, apologies for the delay. We'll get the OCA chased up internally.

Meanwhile, I wonder what you think about my comment here which also applies to your PR too?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement oracle-cla: no Contributor has not yet signed the Oracle Contributor Licence Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants