Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

Add spellcheck tests #228

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add spellcheck tests #228

wants to merge 2 commits into from

Conversation

KashifSaadat
Copy link

@KashifSaadat KashifSaadat commented Sep 28, 2018 •
edited

Changes:

  • Added misspell library and extend tests to perform a spellcheck on golang and markdown files (vendor directory is excluded)
  • Updated docs where the spellcheck test detected typos.

@KashifSaadat
Copy link
Author

Kept the commits separate so they're easier to review.

@KashifSaadat KashifSaadat force-pushed the add-spellcheck branch 2 times, most recently from 3182df9 to 667191a Compare September 28, 2018 15:50
@prydie prydie added needs-approval oracle-cla: yes Contributor has signed the Oracle Contributor Licence Agreement labels Oct 1, 2018
@prydie
Copy link

prydie commented Oct 1, 2018

Thanks for the PR @KashifSaadat 😄!

Would you mind splitting it out into two separate PRs as the two changes are unrelated as far as I can see?

Additionally, we'll probably want to update the CI image to include a prebuilt misspell binary rather than go installing it every time. There's no automation set up for building the CI images so I'm happy to pick up that part of the change if you're happy with me doing so?

@KashifSaadat
Copy link
Author

Hey @prydie, sure that sounds good. I've raised PR #229 with the commit for the RBAC template updates. Shall we close this PR in favour of your CI image update?

@KashifSaadat KashifSaadat changed the title Add spellcheck tests and update RBAC template Add spellcheck tests Oct 4, 2018
@KashifSaadat
Add misspell library and spellcheck test
4348ed1 
Signed-off-by: Kashif Saadat <kashifsaadat@gmail.com>
@KashifSaadat
Correct typos detected in docs for tests to pass
9d9147d 
Signed-off-by: Kashif Saadat <kashifsaadat@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-approval oracle-cla: yes Contributor has signed the Oracle Contributor Licence Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KashifSaadat @prydie