Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to Bootstrap 5.3.3 #4142

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

leigh-pointer
Copy link
Contributor

Update Oqtane Theme to 5.3.3
Reworked Blazor theme to load Resources from Info class. Bootstrap 5.3.3 caused issue with Close button [x] appearing next to the Title and not in the top right corner. Updated Theme Template

Update Oqtane Theme to 5.3.3
Reworked Blazor theme to load Resources from Info class.
Bootstrap 5.3.3 caused issue with Close button [x] appearing next to the Title and not in the top right corner.
Updated Theme Template
@sbwalker
Copy link
Member

sbwalker commented Apr 15, 2024

@leigh-pointer some feedback...

  1. Based on the fact that everytime we update Bootstrap it introduces new cosmetic impacts which are only identified through full regression testing, I am hesitant to introduce this change. You have already identified one "breaking" change which you resolved but it is likely there are more that could impact custom themes and modules. I am actually wondering if it would be better to reserve Bootstrap changes for major releases ie. 5.2.0
  2. The reason why the Blazor Theme is using the older Resource registration within the component is so that it is possible to easily test that both approaches are still working properly in the framework. So I would actually prefer to not make this change to the Blazor theme

@sbwalker
Copy link
Member

@leigh-pointer what is your experience with Bootstrap 5.3.3?

@leigh-pointer
Copy link
Contributor Author

@sbwalker I have had no issues with 5.3.3. I updated my branch with the latest and all is ok in both interactive and static. I would say it is safe to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants