Add navbar #5
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "presets": ["next/babel"], | ||
| "plugins": [["styled-components", { "ssr": true }]] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import styled from 'styled-components'; | ||
| import { Row, Col, Spacer, Select } from '@geist-ui/react'; | ||
| import { Sun, Moon } from '@geist-ui/react-icons'; | ||
|
|
||
| const darkLogo = '/images/opticDarkLogo.png'; | ||
| const lightLogo = '/images/opticLightLogo.png'; | ||
|
|
||
| const NavBar = styled(Row)` | ||
RobertoValle31 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| align-items: center !important; | ||
| height: 50px; | ||
| border-bottom: 0.5px solid; | ||
| margin-bottom: 15px; | ||
| padding: 0px 15px; | ||
| `; | ||
|
|
||
| const Logo = styled.img` | ||
| height: 40px; | ||
| `; | ||
|
|
||
| const SelectContainer = styled(Col)` | ||
| text-align: right; | ||
| `; | ||
|
|
||
| interface NavParams { | ||
| setUseLight(useLight: boolean): any; | ||
| useLight: boolean; | ||
| } | ||
|
|
||
| const Nav = ({ useLight, setUseLight }: NavParams): JSX.Element => { | ||
| return ( | ||
| <NavBar> | ||
| <Col> | ||
| <Logo src={useLight ? darkLogo : lightLogo} alt="OpticPower" /> | ||
| </Col> | ||
| <SelectContainer> | ||
| <Select placeholder={useLight ? 'Light Mode' : 'Dark Mode'}> | ||
| <Select.Option value="Dark Mode" onClick={(): void => setUseLight(false)}> | ||
|
There was a problem hiding this comment. nit: why I had used something like: <Select placeholder={useLight ? 'Light Mode' : 'Dark Mode'} onChange={(ev) => setLight(ev.target.value)}>
<Select.Option value="false">
<Moon size={16} /> <Spacer inline x={0.35} />
Dark Mode
</Select.Option>
{/* ... */}
</Select>Just curious. There was a problem hiding this comment. Hey, @lardissone I was trying your suggestion but I believe that you do that on MaterialUI, and works perfectly. If that is the case the prop <Select placeholder={useLight ? 'Light Mode' : 'Dark Mode'} onChange={value => setUseLight(value === 'true')}>
<Select.Option value="false">
<Moon size={16} /> <Spacer inline x={0.35} />
Dark Mode
</Select.Option>
<Select.Option value="true">
<Sun size={16} /> <Spacer inline x={0.35} />
Light Mode
</Select.Option>
</Select>Let me know what you think. |
||
| <Moon size={16} /> <Spacer inline x={0.35} /> | ||
| Dark Mode | ||
| </Select.Option> | ||
| <Select.Option value="Light Mode" onClick={(): void => setUseLight(true)}> | ||
| <Sun size={16} /> <Spacer inline x={0.35} /> | ||
| Light Mode | ||
| </Select.Option> | ||
| </Select> | ||
| </SelectContainer> | ||
| </NavBar> | ||
| ); | ||
| }; | ||
|
|
||
| export default Nav; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having problems with the styled-components because every time I refreshed the page the component was losing all its CSS styles and I was having a warning on the browser console regarding the use of className although I was not using it. After research and testing different solutions this was the only one that worked vercel/next.js#4068 (comment) I had to create this file with this config.