Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - matrix connector proxy config #2035

Merged
merged 2 commits into from May 3, 2024
Merged

Conversation

Ronan-WeScale
Copy link
Contributor

Description

Matrix connector doesn't support proxy config from ENV var like mattermost connector

Fixes n/a

Status

READY

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Test matrix connection with proxy env var. Work as well

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.74%. Comparing base (e078548) to head (adb2f1c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2035      +/-   ##
==========================================
- Coverage   98.78%   98.74%   -0.04%     
==========================================
  Files          84       84              
  Lines        5427     5421       -6     
==========================================
- Hits         5361     5353       -8     
- Misses         66       68       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I assume if this resolves to None value that is also fine.

@jacobtomlinson jacobtomlinson enabled auto-merge (squash) May 3, 2024 16:11
@tcheksa62
Copy link

Hi I'm Ronan this is my second account. Yes none value don't break the connector.

@jacobtomlinson jacobtomlinson merged commit ed20ee1 into opsdroid:main May 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants