Updated closed connection bug #2012
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
183
to
+184
| message.target = next(iter(self.active_connections)) | ||
| #message.target = next(iter(self.active_connections)) |
There was a problem hiding this comment.
I think these are duplicate lines?
Suggested change
| message.target = next(iter(self.active_connections)) | |
| #message.target = next(iter(self.active_connections)) |
| message.target = open_connections[0] | ||
| else: | ||
| # Handle the case where no open connections are available | ||
| message.target = None # or raise an appropriate exception |
There was a problem hiding this comment.
We should probably raise here
| # Handle the case where no open connections are available | ||
| message.target = None # or raise an appropriate exception | ||
| # When a connection is closed, remove it from active_connections | ||
| if connection in self.active_connections: |
There was a problem hiding this comment.
I'm not sure where this connection variable is being created.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is regarding closed connection ,the issue is whenever there is a connection closed it shows none , so what I have done is I've made it iterate through all open connections it at all no one is free then it shows null