Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple match regexs #2009

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Cadair
Copy link
Contributor

@Cadair Cadair commented Oct 4, 2023

Description

This PR adds the option to use regex.finditer to find all matches in the message string.

Status

UNDER DEVELOPMENT

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (41246da) 99.16% compared to head (a0d21f5) 99.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2009      +/-   ##
==========================================
- Coverage   99.16%   99.13%   -0.04%     
==========================================
  Files          83       83              
  Lines        5395     5407      +12     
==========================================
+ Hits         5350     5360      +10     
- Misses         45       47       +2     
Files Coverage Δ
opsdroid/parsers/regex.py 100.00% <100.00%> (ø)
opsdroid/events.py 96.46% <77.77%> (-0.92%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant