New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wireguard: update dialogEditWireguardClient.xml for minor spelling mistake #7420
base: master
Are you sure you want to change the base?
Conversation
@@ -29,7 +29,7 @@ | |||
<style>tokenize</style> | |||
<type>select_multiple</type> | |||
<allownew>true</allownew> | |||
<help>List of networks allowed to pass trough the tunnel adapter. Use CIDR notation like 10.0.0.0/24.</help> | |||
<help>List of networks allowed to pass through the tunnel adapter. Use CIDR notation like 10.0.0.0/24.</help> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are here can we do this?
<help>List of networks allowed to pass through the tunnel adapter. Use CIDR notation like 10.0.0.0/24.</help> | |
<help>List of networks to route through the tunnel adapter. Use CIDR notation like 10.0.0.0/24.</help> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(all we do is run route add
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's pass and route when "Disable routes" is unchecked, otherwise it's only pass
AllowedIPs = {{ peerlist2_data.tunneladdress }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, my main motivation is to get rid of explaining „allowed“ terminology with „allowed“ in the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit confusing indeed, maybe better to only explain the type of expected input, something like:
Use CIDR notation like 10.0.0.0/24, when routes are enabled one will be added for this network as well.
78845fc
to
8ba454a
Compare
No description provided.