Add karate end to end test for reminder feature (#6385) #6443
Conversation
quinarygio
force-pushed
the
FE-6385-card-reminder-test
branch
from
d8a0be3
to
2dcc515
Compare
| * def hours = new java.lang.Integer(new Date().getHours()) | ||
| * def minutes = new java.lang.Integer(new Date().getMinutes() + 2) | ||
| * def seconds = new java.lang.Integer(new Date().getSeconds()) |
There was a problem hiding this comment.
I think it s gone to create problems particularly when the current time is close to the end of the hour (e.g., 10:59). In such cases, adding 2 minutes would result in a time with 61 minutes, which is not valid.
I suggest to first create a date + 2 min ( new Date().valueOf() + 2*60*1000 )
and then extract hours/minutes/seconds from this new object
|
|
||
|
|
||
| #Create new perimeter | ||
| * callonce read('../common/createPerimeter.feature') {perimeter: '#(perimeter)', token: '#(authTokenAdmin)'} |
There was a problem hiding this comment.
i realize that we are using every where callonce , but we can use call instead in a lot of place (callonce just cache the result , so it is interesting when getting token)
quinarygio
force-pushed
the
FE-6385-card-reminder-test
branch
from
2dcc515
to
0aa1a31
Compare
| * def hours = new java.lang.Integer(new Date().getHours()) | ||
| * def minutes = new java.lang.Integer(new Date(now + 2*60*1000).getMinutes()) | ||
| * def seconds = new java.lang.Integer(new Date().getSeconds()) |
There was a problem hiding this comment.
As for minutes it has to be the same for hours otherwise 9:59 will ends up to 9:01
| * def hours = new java.lang.Integer(new Date().getHours()) | |
| * def minutes = new java.lang.Integer(new Date(now + 2*60*1000).getMinutes()) | |
| * def seconds = new java.lang.Integer(new Date().getSeconds()) | |
| * def datePlus2Min = new java.lang.Integer(new Date(now + 2*60*1000)) | |
| * def hours = new java.lang.Integer(datePlus2Min.getHours()) | |
| * def minutes = new java.lang.Integer(datePlus2Min.getMinutes()) | |
| * def seconds = new java.lang.Integer(datePlus2Min.getSeconds()) | |
Signed-off-by: Giovanni Ferrari <giovanni.ferrari@soft.it>
quinarygio
force-pushed
the
FE-6385-card-reminder-test
branch
from
0aa1a31
to
86085b7
Compare
|
Fix #6385