Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/activate poltergeist for rspec #4916

Closed
wants to merge 5 commits into from

Conversation

ulferts
Copy link
Contributor

@ulferts ulferts commented Oct 7, 2016

No description provided.

@oliverguenther
Copy link
Member

Even the up-to-date PhantomJS 2.1 has significant issues with flexbox.

ariya/phantomjs#14365
ariya/phantomjs#12367

It appears that the workaround from the first issue (adding Safari >= 4) does help somewhat. Let's see what breaks!

screenshot_2016-10-12-10-12-29 430
screenshot_2016-10-12-10-11-22 266

@oliverguenther
Copy link
Member

./spec/features/groups/group_memberships_spec.rb:86 appears to fail because the click is sent to the other button next to it. The triggered link is the remove button, but the coordinates response of PhantomJS with debug enabled return the button left to it. The screenshots confirm, that instead of removing the row, the row is turned into edit mode.

@oliverguenther
Copy link
Member

While this is a valiant effort, after the experiences made here trying to fix the tests, and the results from the cukes running on dev, I suggest we stop this effort. PhantomJS appears to have lots of bugs that happen to be occurring on our application and issues with Flex.

I suggest to revert the cuke change here: #4946

@oliverguenther oliverguenther deleted the feature/activate_poltergeist_for_rspec branch November 7, 2016 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants