Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close cpu profile #1894

Open
wants to merge 1 commit into
base: release-next
Choose a base branch
from
Open

fix: close cpu profile #1894

wants to merge 1 commit into from

Conversation

testwill
Copy link

@testwill testwill commented Apr 4, 2024

No description provided.

@testwill testwill requested review from a team as code owners April 4, 2024 04:01
plorenz
plorenz requested changes Apr 13, 2024
View reviewed changes
Copy link
Member

@plorenz plorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @testwill thanks for the PR. Unfortunately, it doesn't look quite right. The file needs to stay open while the profiler is running. It should be closed in the Run method, after the StopCPUProfile method is called.

@testwill
fix: close cpu profile
83a13ca 
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
@testwill testwill requested a review from plorenz April 15, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plorenz plorenz Awaiting requested review from plorenz

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@testwill @plorenz