Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update controller deploy ref #814

Closed
wants to merge 2 commits into from
Closed

update controller deploy ref #814

wants to merge 2 commits into from

Conversation

qrkourier
Copy link
Member

No description provided.

@qrkourier qrkourier requested review from a team as code owners March 14, 2024 21:19
Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ziti-doc ✅ Ready (Inspect) Visit Preview Mar 19, 2024 7:18pm

@qrkourier
Copy link
Member Author

@dovholuknf Feedback from @emoscardini was move the "Bring Your Own State" section to a separate page instead of cramming everything into one page.

@qrkourier qrkourier changed the title document deploying a controller on Linux update controller deploy ref Mar 22, 2024
@dovholuknf
Copy link
Member

On the whole, there feels like a fair bit of reference-type-words mixed throughout that probably don't belong in a guide-type document. Would you go through and find anything that feels reference-ish and unecessary and remove? IPC Agent is not necessary to understand, SNI and ALPN seem to be reference-related not guide-related to me. There might be other stuff that could be trimmed out as well but as I read through those sorts of things are striking me as not really being inline with what a 'guide' is. some bit of it, is necessary but this should focus more bringing it up and how, not the details under it. it does make me feel like there's some kind of related reference material here that could be exctracted and moved to reference

@qrkourier
Copy link
Member Author

aggregating changes in #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants