[IFRT] Wrap RemapPlan::mappings with shared_ptr #12539
Merged
+44
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_634091756
branch
4 times, most recently
from
d4156ae
to
ac22871
Compare
`xla::ifrt::RemapPlan`'s `mappings` is frequently reused across different `xla::ifrt::RemapPlan`. It can be costly to keep a copy of `mappings` for each plan if the mappings is not trivially small. This change wraps `mappings` with `std::shared_ptr` so that it can be shared more cheaply across multiple plans. PiperOrigin-RevId: 634214931
copybara-service
bot
closed this pull request by merging all changes
into
main
in
89b8b02
copybara-service
bot
force-pushed
the
test_634091756
branch
from
ac22871
to
89b8b02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IFRT] Wrap RemapPlan::mappings with shared_ptr
xla::ifrt::RemapPlan'smappingsis frequently reused across differentxla::ifrt::RemapPlan. It can be costly to keep a copy ofmappingsfor eachplan if the mappings is not trivially small.
This change wraps
mappingswithstd::shared_ptrso that it can be sharedmore cheaply across multiple plans.