Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] Fix build break introduced in ffa7bb5 and df736d7 #12515

Closed
wants to merge 1 commit into from
Closed

[ROCm] Fix build break introduced in ffa7bb5 and df736d7 #12515

wants to merge 1 commit into from

Conversation

hsharsha
Copy link
Contributor

Fix build break introduced in ffa7bb5 and df736d7

@github-actions github-actions bot added the kokoro:force-run Forces CI to rerun label May 15, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label May 15, 2024
@i-chaochen
Copy link
Contributor

@ddunl @xla-rotation please check it. Thanks!

copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request May 15, 2024
@hsharsha @tensorflower-gardener
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
18a5d03 
Imported from GitHub PR openxla/xla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687ea87e38be681cb978d15ebd314377623c4 by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12515 from ROCm:ci_fix_build_break_20240515 499687ea87e38be681cb978d15ebd314377623c4
PiperOrigin-RevId: 633965903
@copybara-service copybara-service bot mentioned this pull request May 15, 2024
Closed
@dimitar-asenov
Copy link
Member

@ddunl This breaks our internal build and my attempts at fixing it weren't successful, could you please take a look and suggest a good way to land this fix? Thanks!

copybara-service bot pushed a commit that referenced this pull request May 17, 2024
@hsharsha
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
0382571 
Imported from GitHub PR #12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687e by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12515 from ROCm:ci_fix_build_break_20240515 499687e
PiperOrigin-RevId: 634691871
@copybara-service copybara-service bot mentioned this pull request May 17, 2024
Open
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request May 17, 2024
@hsharsha @tensorflower-gardener
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
9b7941d 
Imported from GitHub PR openxla/xla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687ea87e38be681cb978d15ebd314377623c4 by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12515 from ROCm:ci_fix_build_break_20240515 499687ea87e38be681cb978d15ebd314377623c4
PiperOrigin-RevId: 634691871
@copybara-service copybara-service bot mentioned this pull request May 17, 2024
Closed
copybara-service bot pushed a commit that referenced this pull request May 17, 2024
@hsharsha
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
844e94d 
Imported from GitHub PR #12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687e by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12515 from ROCm:ci_fix_build_break_20240515 499687e
PiperOrigin-RevId: 634691871
copybara-service bot pushed a commit that referenced this pull request May 17, 2024
@hsharsha
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
942fc4b 
Imported from GitHub PR #12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687e by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12515 from ROCm:ci_fix_build_break_20240515 499687e
PiperOrigin-RevId: 633993125
@copybara-service copybara-service bot mentioned this pull request May 17, 2024
Merged
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request May 17, 2024
@hsharsha @tensorflower-gardener
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
9182d0d 
Imported from GitHub PR openxla/xla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687ea87e38be681cb978d15ebd314377623c4 by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12515 from ROCm:ci_fix_build_break_20240515 499687ea87e38be681cb978d15ebd314377623c4
PiperOrigin-RevId: 633993125
@copybara-service copybara-service bot mentioned this pull request May 17, 2024
Merged
copybara-service bot pushed a commit that referenced this pull request May 17, 2024
@hsharsha
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
827a55f 
Imported from GitHub PR #12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687e by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12515 from ROCm:ci_fix_build_break_20240515 499687e
PiperOrigin-RevId: 633993125
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request May 17, 2024
@hsharsha @tensorflower-gardener
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
d05b43f 
Imported from GitHub PR openxla/xla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687ea87e38be681cb978d15ebd314377623c4 by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12515 from ROCm:ci_fix_build_break_20240515 499687ea87e38be681cb978d15ebd314377623c4
PiperOrigin-RevId: 633993125
copybara-service bot pushed a commit that referenced this pull request May 17, 2024
@hsharsha
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
ba8e99c 
Imported from GitHub PR #12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687e by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=#12515 from ROCm:ci_fix_build_break_20240515 499687e
PiperOrigin-RevId: 633993125
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request May 17, 2024
@hsharsha @tensorflower-gardener
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
f2a5d30 
Imported from GitHub PR openxla/xla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687ea87e38be681cb978d15ebd314377623c4 by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12515 from ROCm:ci_fix_build_break_20240515 499687ea87e38be681cb978d15ebd314377623c4
PiperOrigin-RevId: 633993125
@dimitar-asenov
Copy link
Member

The breakage introduced by df736d7 was fixed in a previous change, so I'm submitting just the part of this PR that fixes the breakage introduced by ffa7bb5.

copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request May 17, 2024
@tensorflower-gardener
Automated Code Change
2c52032 
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#12515 from ROCm:ci_fix_build_break_20240515 499687ea87e38be681cb978d15ebd314377623c4
PiperOrigin-RevId: 634191675
@copybara-service copybara-service bot mentioned this pull request May 17, 2024
Merged
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request May 17, 2024
@hsharsha @tensorflower-gardener
PR #12515: [ROCm] Fix build break introduced in ffa7bb5 and df736d7
cd5779d 
Imported from GitHub PR openxla/xla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687ea87e38be681cb978d15ebd314377623c4 by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes #12515

PiperOrigin-RevId: 634713247
Ruturaj4 pushed a commit to ROCm/xla that referenced this pull request May 17, 2024
@hsharsha @Ruturaj4
PR openxla#12515: [ROCm] Fix build break introduced in ffa7bb5 and df…
ae9dba2 
…736d7

Imported from GitHub PR openxla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687e by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes openxla#12515

COPYBARA_INTEGRATE_REVIEW=openxla#12515 from ROCm:ci_fix_build_break_20240515 499687e
PiperOrigin-RevId: 634713247
Ruturaj4 pushed a commit to ROCm/xla that referenced this pull request May 30, 2024
@hsharsha
PR openxla#12515: [ROCm] Fix build break introduced in ffa7bb5 and df…
ebf4374 
…736d7

Imported from GitHub PR openxla#12515

Fix build break introduced in ffa7bb5 and df736d7
Copybara import of the project:

--
499687e by Harsha HS <harsha.havanurshamsundara@amd.com>:

Fix build break introduced in ffa7bb5 and df736d7

Merging this change closes openxla#12515

COPYBARA_INTEGRATE_REVIEW=openxla#12515 from ROCm:ci_fix_build_break_20240515 499687e
PiperOrigin-RevId: 634713247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddunl ddunl ddunl approved these changes

Assignees

@xla-rotation xla-rotation

@kamaljeeti kamaljeeti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hsharsha @i-chaochen @dimitar-asenov @ddunl @kokoro-team @xla-rotation @kamaljeeti